Use lock to fix issue with parallel invocations #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues with errors like under Linux: ``` Opening zip "/(...)/downloads/sha256/c97f(...)/bin/bazel (deleted)": open(): No such file or directory FATAL: Failed to open '/(...)/downloads/sha256/c97f(...)/bin/bazel (deleted)' as a zip file: (error: 2): No such file or directory ``` and below ones under Windows: ``` could not download Bazel: failed to download bazel: failed to move (...) (...)\bin\bazel.exe: Access is denied. ``` See: bazelbuild#436 Tested using `parallel_bazelisk_bug.go` script under Linux and Windows that this change fixes issue.
fweikert
approved these changes
Dec 2, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with errors like under Linux:
and below ones under Windows:
See: #436
Tested using
parallel_bazelisk_bug.goscript under Linux and Windows that this change fixes issue.