Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close response body before retry #627

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Close response body before retry #627

merged 3 commits into from
Nov 5, 2024

Conversation

meteorcloudy
Copy link
Member

Hopefully fixes #626

@meteorcloudy meteorcloudy requested a review from fweikert November 5, 2024 14:42
@meteorcloudy
Copy link
Member Author

I haven't found a way to reproduce the INTERNAL_ERROR locally.

@meteorcloudy
Copy link
Member Author

Actually I managed to reproduce by running bazel info output_base in parallel. Verifying if this change helps.

@meteorcloudy
Copy link
Member Author

I cannot reproduce the same error anymore after this change, looks like it worked!

@meteorcloudy meteorcloudy merged commit c0b7400 into bazelbuild:master Nov 5, 2024
2 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 5, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fweikert fweikert fweikert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bazelisk sometimes fails to download Bazel binaries
2 participants
@meteorcloudy @fweikert