Fix races on temporary file copies #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushain97
commented
Sep 30, 2024
| if err != nil { | ||
| return fmt.Errorf("failed to create temporary file in %s: %w", parent, err) | ||
| } | ||
| defer os.Remove(tmpFile.Name()) |
There was a problem hiding this comment.
This is a no-op unless the write fails and the rename never happens.
|
@fweikert 👋 anything I can help with to get this PR merged? |
fweikert
approved these changes
Oct 9, 2024
|
Thank you! |
|
Hi, when should we expect a release with this change? |
https://github.com/bazelbuild/bazelisk/releases/tag/v1.22.1 |
1 task
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two instances of Bazelisk are running concurrently and downloading Bazel, the current code admits a race. This patch fixes the issue by using randomly named files for temporary paths.
For example: