Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve last green commit support #614

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Sep 25, 2024

  • Fetch last green commit from https://storage.googleapis.com/bazel-builds/last_green_commit/github.com/bazelbuild/bazel.git/publish-bazel-binaries which is generated by the trusted Bazel CI org.
  • Validate the format of the commit hash fetched
  • Removed support for last_downstream_green. The downstream pipeline hasn't been green for more than a year, there is not much point of using this commit for fetching Bazel binary.

@fweikert fweikert merged commit d22deda into bazelbuild:master Sep 30, 2024
2 checks passed
zemnmez-renovate-bot added a commit to zemn-me/monorepo that referenced this pull request Sep 30, 2024
##### [`v1.22.0](https://github.com/bazelbuild/bazelisk/releases/tag/v1.22.0)

Bazelisk v1.22.0 comes with several significant changes:

### New Features (Go)

-   Bazelisk sets the `BAZELISK` env variable so that scripts can detect whether they're running under Bazelisk (bazelbuild/bazelisk#612)
-   `--bisect` now supports finding the first *fixing* commit by prefixing the range with `~` (bazelbuild/bazelisk#613)

### Removed Features (Go)

-   Removed support for `last_downstream_green` since the downstream pipeline stopped producing green commits some time ago.

### Bug Fixes & Improvements

-   Improved `last_green` support (bazelbuild/bazelisk#614)

We’d like to thank our amazing contributors [@fmeum](https://github.com/fmeum) and [@jwnimmer-tri](https://github.com/jwnimmer-tri)!
github-merge-queue bot pushed a commit to zemn-me/monorepo that referenced this pull request Sep 30, 2024
##### [`v1.22.0](https://github.com/bazelbuild/bazelisk/releases/tag/v1.22.0)

Bazelisk v1.22.0 comes with several significant changes:

### New Features (Go)

-   Bazelisk sets the `BAZELISK` env variable so that scripts can detect whether they're running under Bazelisk (bazelbuild/bazelisk#612)
-   `--bisect` now supports finding the first *fixing* commit by prefixing the range with `~` (bazelbuild/bazelisk#613)

### Removed Features (Go)

-   Removed support for `last_downstream_green` since the downstream pipeline stopped producing green commits some time ago.

### Bug Fixes & Improvements

-   Improved `last_green` support (bazelbuild/bazelisk#614)

We’d like to thank our amazing contributors [@fmeum](https://github.com/fmeum) and [@jwnimmer-tri](https://github.com/jwnimmer-tri)!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants