Fetch bazel binaries for commits on linux arm64 #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fweikert
approved these changes
Aug 21, 2024
|
thanks! can you create a release with this in it? 🙏🏻 |
1 task
|
thanks! |
keith
added a commit
to keith/buildbuddy
that referenced
this pull request
Dec 19, 2024
This pulls in bazelbuild/bazelisk#604 to allow downloading bazel commits on aarch64 linux. The only weird thing about this is we now provide a repo_mapping to that repo because it started using the new bzlmod names for rules_go and gazelle. This doesn't upgrade to the latest version of bazelisk because that would require other API changes.
keith
added a commit
to keith/buildbuddy
that referenced
this pull request
Dec 19, 2024
This pulls in bazelbuild/bazelisk#604 to allow downloading bazel commits on aarch64 linux. The only weird thing about this is we now provide a repo_mapping to that repo because it started using the new bzlmod names for rules_go and gazelle. This doesn't upgrade to the latest version of bazelisk because that would require other API changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on bazelbuild/continuous-integration#2022
Fixes #317
Bazel commits after bazelbuild/bazel@5aaffc3 will be supported for Linux arm64.
We've been publishing under both "linux" and "centos7" for x64 binaries for a long time, so it should be fine to switch the name.