.bazeliskrc: Add Support for Env Var and Tilde Expansion
#587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to handle env variables and tilde expansion in .bazeliskrc
|
Hi @fweikert, could you or someone please review this PR when you have a chance? Thanks! |
|
Hey @fweikert, just wondering if you have any comments on this as I'm really keen to get this implemented and stop using a fork 😅. Thanks! (Happy to change the else clause for an early return if makes more readable. I tried to follow my perception of the code "convention") |
fweikert
approved these changes
Jul 9, 2024
|
Ah, I was too quick to merge. Yeah, I would have preferred an early return, too, but didn't want to block the PR on it. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to add support for env expansion as
os.MkdirAllwill treat shell variables and~as literals.Fixes #586