-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding tools/bazel path with BAZELISK_WRAPPER_DIRECTORY #567
Allow overriding tools/bazel path with BAZELISK_WRAPPER_DIRECTORY #567
Conversation
+1 we'd love this primarily to fix #577 |
@fweikert ptal |
One downside with this is that scripts that recursively call into |
yea i guess that's up to the user to manage if they rely on that. we could alternatively just allow a different directory vs different file name, since I imagine that's the more common thing that's important to override. |
I'd be happy with different directory if it helps with the issue Brentley mentioned |
It wouldn't entirely be in control of the user though, because the scripts I'm talking about are run targets, like rules_xcodeproj's project generation. So I would prefer to limit it to the directory if possible. |
In some projects the tools/bazel path isn't practical. This allows users to override this path with the BAZELISK_WRAPPER_PATH env var / .bazeliskrc config option.
0bc50ca
to
3b95294
Compare
updated |
Thank you! |
thanks! |
In some projects the tools/bazel path isn't practical. This allows users to override this path with the BAZELISK_WRAPPER_DIRECTORY env var / .bazeliskrc config option. This allows overriding the root
directory that the
bazel
wrapper executable should be found in. This was chosen over the file itselfin order to continue supporting recursive
bazel
invocations.