Allow retrying on non-HTTP errors #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fweikert
approved these changes
Jan 19, 2024
|
Thanks! I merged #530, so you can rerun the tests here. |
bazelbuild@787006c added support for retrying HTTP errors, this extend that to retry when an HTTP connection cannot be made. This helps when bazelisk failes to speak HTTP: 2024/01/16 14:31:11 could not download Bazel: HTTP GET https://releases.bazel.build/7.0.0/release/bazel-7.0.0-linux-x86_64 failed: Get "https://releases.bazel.build/7.0.0/release/bazel-7.0.0-linux-x86_64": dial tcp 130.211.22.235:443: i/o timeout Fixes: bazelbuild#432
ti-chi-bot bot
referenced
this pull request
in PingCAP-QE/artifacts
Jul 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [bazelbuild/bazelisk](https://togithub.com/bazelbuild/bazelisk) | minor | `v1.19.0` -> `v1.20.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/bazelisk (bazelbuild/bazelisk)</summary> ### [`v1.20.0`](https://togithub.com/bazelbuild/bazelisk/releases/tag/v1.20.0) [Compare Source](https://togithub.com/bazelbuild/bazelisk/compare/v1.19.0...v1.20.0) Bazelisk v1.20.0 comes with several significant changes: ### New Features - The Go version now supports `BAZELISK_NOJDK` ([https://github.com/bazelbuild/bazelisk/pull/531](https://togithub.com/bazelbuild/bazelisk/pull/531)) ### Bug Fixes & Improvements - It's now easier to use Bazelisk programmatically ([https://github.com/bazelbuild/bazelisk/pull/500](https://togithub.com/bazelbuild/bazelisk/pull/500), [https://github.com/bazelbuild/bazelisk/pull/526](https://togithub.com/bazelbuild/bazelisk/pull/526)) - Bazelisk will retry more connection errors ([https://github.com/bazelbuild/bazelisk/pull/529](https://togithub.com/bazelbuild/bazelisk/pull/529), [https://github.com/bazelbuild/bazelisk/pull/530](https://togithub.com/bazelbuild/bazelisk/pull/530)) - A display bug in the download progress bar has been fixed ([https://github.com/bazelbuild/bazelisk/pull/539](https://togithub.com/bazelbuild/bazelisk/pull/539)) We’d like to thank our amazing contributors [@​afq984](https://togithub.com/afq984), [@​comius](https://togithub.com/comius), [@​francine-blanc](https://togithub.com/francine-blanc), [@​illicitonion](https://togithub.com/illicitonion), [@​jwnimmer-tri](https://togithub.com/jwnimmer-tri), [@​LINKIWI](https://togithub.com/LINKIWI), [@​mmorel-35](https://togithub.com/mmorel-35) and [@​sf-jbazuzi](https://togithub.com/sf-jbazuzi)! </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/PingCAP-QE/artifacts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJoZWxwIHdhbnRlZCJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
787006c added support for retrying HTTP errors, this extend that to retry when an HTTP connection cannot be made.
This helps when bazelisk failes to speak HTTP:
Fixes: #432