-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OS-specific BAZELISK_HOME #474
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@fweikert could you take a look? Thanks in advance :) |
@fweikert - could you please have a look on that change ? |
@katre can you maybe help here ? |
@fweikert any update on this ? |
@fweikert @meteorcloudy - Can we get this merged please ? We would like to start using your official releases. |
@mzapotoczny thanks for this change, I took the liberty of resolving the merge conflict. |
BAZELISK_HOME
should be set as absolute path, but all supported OSes use different folder structure. This might be a problem if we want to globally setBAZELISK_HOME
for all developers.Therefore we want to propose a change to add support for OS-specific
BAZELISK_HOME
, for exampleBAZELISK_HOME_WINDOWS
.