Revert "Enabling Bazel to generate input symlinks as defined by RE AP… #7216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I V2." This reverts commit baa1786. The symlink resolution in this change is broken, as it does not take into account parent symlinks. Consider the following structure on the filesystem: a/d/file a/b/c/symlink -> ../../d/file And action inputs as follows: a/d/file (f -> a/b/c)/symlink -> ../../d/file with (f -> a/b/c) denoting that f is a symlink to directory c. This change then builds the following merkle tree: a d file f symlink -> ../../d/file My guesstimate is that there are a number of additional problems with this change and we should think hard about them when attempting to roll foward this change in the future. See for example Bazel's symlink resolution in FileFunction [1]. A real world example of this error is: bazelbuild#7212 Fixes bazelbuild#7212 [1] https://source.bazel.build/bazel/+/master:src/main/java/com/google/devtools/build/lib/skyframe/FileFunction.java;l=114?q=FileFunction
buchgr
force-pushed
the
revert-input-symlinks
branch
from
67b4065 to
bbd456f
Compare
philwo
approved these changes
Jan 22, 2019
|
Thanks! |
aehlig
pushed a commit
that referenced
this pull request
Jan 23, 2019
?I V2." This reverts commit baa1786. The symlink resolution in this change is broken, as it does not take into account parent symlinks. Consider the following structure on the filesystem: ``` a/d/file a/b/c/symlink -> ../../d/file ``` And action inputs as follows: ``` a/d/file (f -> a/b/c)/symlink -> ../../d/file ``` with (f -> a/b/c) denoting that f is a symlink to directory c. This change then builds the following merkle tree: ``` a d file f symlink -> ../../d/file ``` My guesstimate is that there are a number of additional problems with this change and we should think hard about them when attempting to roll foward this change in the future. See for example Bazel's symlink resolution in FileFunction [1]. A real world example of this error is: #7212 Fixes #7212 [1] https://source.bazel.build/bazel/+/master:src/main/java/com/google/devtools/build/lib/skyframe/FileFunction.java;l=114?q=FileFunction Closes #7216. PiperOrigin-RevId: 230527829
aehlig
pushed a commit
that referenced
this pull request
Jan 23, 2019
?I V2." This reverts commit baa1786. The symlink resolution in this change is broken, as it does not take into account parent symlinks. Consider the following structure on the filesystem: ``` a/d/file a/b/c/symlink -> ../../d/file ``` And action inputs as follows: ``` a/d/file (f -> a/b/c)/symlink -> ../../d/file ``` with (f -> a/b/c) denoting that f is a symlink to directory c. This change then builds the following merkle tree: ``` a d file f symlink -> ../../d/file ``` My guesstimate is that there are a number of additional problems with this change and we should think hard about them when attempting to roll foward this change in the future. See for example Bazel's symlink resolution in FileFunction [1]. A real world example of this error is: #7212 Fixes #7212 [1] https://source.bazel.build/bazel/+/master:src/main/java/com/google/devtools/build/lib/skyframe/FileFunction.java;l=114?q=FileFunction Closes #7216. PiperOrigin-RevId: 230527829
weixiao-huang
pushed a commit
to weixiao-huang/bazel
that referenced
this pull request
Jan 31, 2019
?I V2." This reverts commit baa1786. The symlink resolution in this change is broken, as it does not take into account parent symlinks. Consider the following structure on the filesystem: ``` a/d/file a/b/c/symlink -> ../../d/file ``` And action inputs as follows: ``` a/d/file (f -> a/b/c)/symlink -> ../../d/file ``` with (f -> a/b/c) denoting that f is a symlink to directory c. This change then builds the following merkle tree: ``` a d file f symlink -> ../../d/file ``` My guesstimate is that there are a number of additional problems with this change and we should think hard about them when attempting to roll foward this change in the future. See for example Bazel's symlink resolution in FileFunction [1]. A real world example of this error is: bazelbuild#7212 Fixes bazelbuild#7212 [1] https://source.bazel.build/bazel/+/master:src/main/java/com/google/devtools/build/lib/skyframe/FileFunction.java;l=114?q=FileFunction Closes bazelbuild#7216. PiperOrigin-RevId: 230527829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…I V2."
This reverts commit baa1786.
The symlink resolution in this change is broken, as it does not take into
account parent symlinks. Consider the following structure on the filesystem:
And action inputs as follows:
with (f -> a/b/c) denoting that f is a symlink to directory c.
This change then builds the following merkle tree:
My guesstimate is that there are a number of additional problems with
this change and we should think hard about them when attempting to
roll foward this change in the future. See for example Bazel's symlink
resolution in FileFunction [1].
A real world example of this error is: #7212
Fixes #7212
[1] https://source.bazel.build/bazel/+/master:src/main/java/com/google/devtools/build/lib/skyframe/FileFunction.java;l=114?q=FileFunction