Add path mapping support for C++ compile action templates #22890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keith Any idea why this test may be failing on macOS? Does Apple lld not support |
|
Apple's linker does not support start-lib/end-lib. ld64.lld from llvm does since looks like version 14+ |
|
@keith I added |
|
looks like it's the remote only test (at least on the last failure), isn't this where the remote executor has to duplicate the logic around setting DEVELOPER_DIR? |
fmeum
force-pushed
the
6526-cpp-tree-artifact
branch
from
82ef24e to
d34c65d
Compare
fmeum
force-pushed
the
6526-cpp-tree-artifact
branch
from
d34c65d to
2584270
Compare
github-actions
bot
added
team-Rules-CPP
comius
approved these changes
Jul 5, 2024
comius
added
awaiting-PR-merge
|
@bazel-io fork 7.3.0 |
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io fork 7.4.0 |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Aug 19, 2024
C++ action templates are now properly path mapped. Since the default Unix toolchain doesn't support object file groups on macOS, `apple_support` is needed in the test. This requires wiring up `LocalEnvProvider` in the remote worker to get `DEVELOPER_DIR` to be set, which in turn requires improving the runfiles handling for the the worker. Work towards bazelbuild#6526 Closes bazelbuild#22890. PiperOrigin-RevId: 657733074 Change-Id: I132e338d7a44964a8a1aad3062a5c9a4c8e79e57
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
…3349) C++ action templates are now properly path mapped. Since the default Unix toolchain doesn't support object file groups on macOS, `apple_support` is needed in the test. This requires wiring up `LocalEnvProvider` in the remote worker to get `DEVELOPER_DIR` to be set, which in turn requires improving the runfiles handling for the the worker. Work towards #6526 Closes #22890. PiperOrigin-RevId: 657733074 Change-Id: I132e338d7a44964a8a1aad3062a5c9a4c8e79e57 Commit 23f3be0 Co-authored-by: Googler <[email protected]>
|
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ action templates are now properly path mapped.
Since the default Unix toolchain doesn't support object file groups on macOS,
apple_supportis needed in the test. This requires wiring upLocalEnvProviderin the remote worker to getDEVELOPER_DIRto be set, which in turn requires improving the runfiles handling for the the worker.Work towards #6526