Polish Bazel external dependencies #20042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
meteorcloudy
force-pushed
the
workspace_suffix
branch
2 times, most recently
from
a3bade0 to
18d39cb
Compare
meteorcloudy
force-pushed
the
workspace_suffix
branch
from
8b80dd9 to
6600d6f
Compare
meteorcloudy
force-pushed
the
workspace_suffix
branch
from
f74b5f8 to
fcd9bdd
Compare
meteorcloudy
changed the title
Wyverald
reviewed
Nov 6, 2023
distdir_deps.bzl
Outdated
| "~grpc_repo_deps_ext~envoy_api", | ||
| "~grpc_repo_deps_ext~rules_cc", # TODO: Should be removed | ||
| ]] | ||
| """WORKSPACE default repository definitions.""" |
There was a problem hiding this comment.
IIUC there's no reason this file should be called 'distdir_deps' anymore, right? It only contains information about WORKSPACE suffix repos, which are (for example) not used by Bzlmod builds at all.
There was a problem hiding this comment.
Make sense, I renamed it to workspace_deps.bzl
|
This is a really nice cleanup! I'd like to wait for Tony's review too. |
aiuto
reviewed
Nov 6, 2023
sgowroji
added
the
team-ExternalDeps
aiuto
approved these changes
Nov 7, 2023
github-actions
bot
removed
the
awaiting-review
meteorcloudy
added a commit
to meteorcloudy/bazel
that referenced
this pull request
Nov 8, 2023
Clean up and polish Bazel's external dependencies declarations:
- Gathered all repository declarations in `repositories.bzl` file.
- Removed most of repo definitions in `distdir_deps.bzl` and renamed it to `workspace_deps.bzl`, the rest repo definitions are only used in WORKSPACE suffix and test setup.
- Added a repo cache for the workspace repos so that we can decouple repo cache used by
- dependencies used to build and test Bazel: cached by `//src:test_repos`
- dependencies embedded in MODULE.tools: cached by `@bazel_tools_repo_cache//:files`
- dependencies embedded in WORKSPACE suffix: cached by `@workspace_repo_cache//:files`
- Removed unused macros from `distdir.bzl`
This PR largely simplifies `distdir_deps.bzl`, which is also loaded in internal codebase because `gen_workspace_stanza` is a build rule.
Closes bazelbuild#20042.
PiperOrigin-RevId: 580212706
Change-Id: I91a9f7bbf89b9af15fdb98f387d95a40a89e7700
meteorcloudy
added a commit
to meteorcloudy/bazel
that referenced
this pull request
Nov 8, 2023
Clean up and polish Bazel's external dependencies declarations:
- Gathered all repository declarations in `repositories.bzl` file.
- Removed most of repo definitions in `distdir_deps.bzl` and renamed it to `workspace_deps.bzl`, the rest repo definitions are only used in WORKSPACE suffix and test setup.
- Added a repo cache for the workspace repos so that we can decouple repo cache used by
- dependencies used to build and test Bazel: cached by `//src:test_repos`
- dependencies embedded in MODULE.tools: cached by `@bazel_tools_repo_cache//:files`
- dependencies embedded in WORKSPACE suffix: cached by `@workspace_repo_cache//:files`
- Removed unused macros from `distdir.bzl`
This PR largely simplifies `distdir_deps.bzl`, which is also loaded in internal codebase because `gen_workspace_stanza` is a build rule.
Closes bazelbuild#20042.
PiperOrigin-RevId: 580212706
Change-Id: I91a9f7bbf89b9af15fdb98f387d95a40a89e7700
meteorcloudy
added a commit
that referenced
this pull request
Nov 8, 2023
Clean up and polish Bazel's external dependencies declarations: - Gathered all repository declarations in `repositories.bzl` file. - Removed most of repo definitions in `distdir_deps.bzl` and renamed it to `workspace_deps.bzl`, the rest repo definitions are only used in WORKSPACE suffix and test setup. - Added a repo cache for the workspace repos so that we can decouple repo cache used by - dependencies used to build and test Bazel: cached by `//src:test_repos` - dependencies embedded in MODULE.tools: cached by `@bazel_tools_repo_cache//:files` - dependencies embedded in WORKSPACE suffix: cached by `@workspace_repo_cache//:files` - Removed unused macros from `distdir.bzl` This PR largely simplifies `distdir_deps.bzl`, which is also loaded in internal codebase because `gen_workspace_stanza` is a build rule. Closes #20042. PiperOrigin-RevId: 580212706 Change-Id: I91a9f7bbf89b9af15fdb98f387d95a40a89e7700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up and polish Bazel's external dependencies declarations:
repositories.bzlfile.distdir_deps.bzland renamed it toworkspace_deps.bzl, the rest repo definitions are only used in WORKSPACE suffix and test setup.//src:test_repos@bazel_tools_repo_cache//:files@workspace_repo_cache//:filesdistdir.bzlThis PR largely simplifies
distdir_deps.bzl, which is also loaded in internal codebase becausegen_workspace_stanzais a build rule.