Flip --incompatible_disable_objc_library_transition #19433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
force-pushed
the
ks/flip-incompatible_disable_objc_library_transition
branch
3 times, most recently
from
22a8ebd to
4dbca8a
Compare
keith
force-pushed
the
ks/flip-incompatible_disable_objc_library_transition
branch
from
4dbca8a to
b3fed5c
Compare
|
@comius ok I think we're good here |
github-actions
bot
added
the
awaiting-review
keith
commented
Sep 6, 2023
| @@ -690,6 +690,7 @@ protected Artifact j2objcArchive(String j2objcLibraryTarget, String javaTargetNa | |||
|
|
|||
| @Test | |||
| public void testJ2ObjcInformationExportedFromObjcLibrary() throws Exception { | |||
| setBuildLanguageOptions("--incompatible_disable_objc_library_transition=false"); | |||
There was a problem hiding this comment.
flipping it back on these 2 was a cop out, it would be great if someone who knew the impact of j2objc changes here could review and recommend the right solution
|
@comius bump |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.