Bump c++ standard to c++14 per default #18280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting-review
davido
changed the title
Fixes: bazelbuild#18181. Closes: bazelbuild#18280.
davido
force-pushed
the
bump-cpp-standard-per-default
branch
from
f52c6c5 to
94ed186
Compare
oquenchil
approved these changes
May 5, 2023
oquenchil
added
awaiting-PR-merge
|
Why is the c++ standard hardcoded at all? Shouldn't the c++ standard be a feature selectable by the user of the toolchain? The current hardcoding either leads to users relying on ordering of parameters passed to the compiler or encourages vendoring and modification of the toolchain. |
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
May 5, 2023
Mirroring bazelbuild/bazel#18280 so it's easier to swap between the toolchains
Pavank1992
removed
the
awaiting-PR-merge
werkt
added a commit
to buildfarm/tools_remote
that referenced
this pull request
May 10, 2023
Bazel 6.2 has introduced warnings promoted to errors via jdk flags that prevent grpc 1.44.1 from working. Upgrading that to 1.55.1 This introduced an incompatibility with rules_skylib. Upgrading that to 1.4.1 from 0.9.0. Also incompatible was rules_jvm_external, which was upgraded to 5.2 from 4.2. Lastly, absl as used by protobuf at the new grpc version is incompatible with < c++14. Introduced a .bazelrc as a poor excuse for toolchain injection. Bazel will default to c++14 (from c++0x) with a release that includes bazelbuild/bazel#18280. An issue to remove this file will follow. Tagged the build with .bazelversion to avoid accidental consumption of incompatible bazels with bazelisk. Fixes #28
werkt
added a commit
to buildfarm/tools_remote
that referenced
this pull request
May 10, 2023
Bazel 6.2 has introduced warnings promoted to errors via jdk flags that prevent grpc 1.44.1 from working. Upgrading that to 1.55.1 This introduced an incompatibility with rules_skylib. Upgrading that to 1.4.1 from 0.9.0. Also incompatible was rules_jvm_external, which was upgraded to 5.2 from 4.2. Lastly, absl as used by protobuf at the new grpc version is incompatible with < c++14. Introduced a .bazelrc as a poor excuse for toolchain injection. Bazel will default to c++14 (from c++0x) with a release that includes bazelbuild/bazel#18280. An issue to remove this file will follow. Tagged the build with .bazelversion to avoid accidental consumption of incompatible bazels with bazelisk. Fixes #28
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
May 15, 2023
Mirroring bazelbuild/bazel#18280 so it's easier to swap between the toolchains
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Fixes: bazelbuild#18181. Closes: bazelbuild#18280. Closes bazelbuild#18280. PiperOrigin-RevId: 530246609 Change-Id: I6b49d1bd827e98ca65db87c34c1bb13106ffc232
thii
pushed a commit
to thii/bazel
that referenced
this pull request
Oct 11, 2023
Fixes: bazelbuild#18181. Closes: bazelbuild#18280. Closes bazelbuild#18280. PiperOrigin-RevId: 530246609 Change-Id: I6b49d1bd827e98ca65db87c34c1bb13106ffc232 (cherry picked from commit 978cd23)
thii
pushed a commit
to thii/bazel
that referenced
this pull request
Oct 11, 2023
Fixes: bazelbuild#18181. Closes: bazelbuild#18280. Closes bazelbuild#18280. PiperOrigin-RevId: 530246609 Change-Id: I6b49d1bd827e98ca65db87c34c1bb13106ffc232 (cherry picked from commit 978cd23)
keertk
pushed a commit
that referenced
this pull request
Oct 16, 2023
Fixes: #18181. Closes: #18280. Closes #18280. PiperOrigin-RevId: 530246609 Change-Id: I6b49d1bd827e98ca65db87c34c1bb13106ffc232 (cherry picked from commit 978cd23) Co-authored-by: David Ostrovsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18181.
Closes: #18280.