Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix android emulator darwin_arm64 select #15092

Closed
wants to merge 1 commit into from
Closed

Fix android emulator darwin_arm64 select #15092

wants to merge 1 commit into from

Conversation

keith
Copy link
Member

@keith keith commented Mar 21, 2022

This fixes this condition printing a strange error if you try to run
these on macOS. In general this still doesn't work because of
#7069 but if we ever want to
support it this is a pre-requisite to supporting arm macs

@keith
Fix android emulator darwin_arm64 select
9bc4f3b 
This fixes this condition printing a strange error if you try to run
these on macOS. In general this still doesn't work because of
bazelbuild#7069 but if we ever want to
support it this is a pre-requisite to supporting arm macs
@keith keith requested review from ahumesky and ted-xie as code owners March 21, 2022 16:55
@ckolli5 ckolli5 added the team-Android Issues for Android team label Mar 22, 2022
@ted-xie
Copy link
Contributor

ted-xie commented Apr 25, 2022

Hi Keith,

Thank you for this PR! At a glance it looks pretty low-risk. It looks like this is related to compiling Android projects on M1 Macs. Do you know how we could validate this fix on our own M1 machines, and have you done the same test on your own machine? What bug did this PR solve? In general, some more documentation around the select would be helpful context for maintainers.

@keith
Copy link
Member Author

keith commented Apr 25, 2022

Trying to run an emulator test on macOS will first fail with this:

ERROR: /private/var/tmp/_bazel_snowp/5f415e59f25252568cd030dfdb79d872/external/android_test_support/tools/android/emulated_devices/generic_phone/BUILD.bazel:43:12: Creating Android image for @android_test_support//tools/android/emulated_devices/generic_phone:android_28_x86 failed: missing input file 'external/androidsdk/emulator/qemu/darwin-x86_64/qemu-system-i386', owner: '@androidsdk//:emulator/qemu/darwin-x86_64/qemu-system-i386'

As I mentioned this doesn't make these tests fully work, but this error looked more like an infrastructure error than a behavior limitation to the person who hit it here, which confused them into thinking it was just a misconfiguration.

@ted-xie
Copy link
Contributor

ted-xie commented Apr 25, 2022

Thanks for the background. Overall looks good to me; I'll start importing this and let you know if there are any show stoppers.

@bazel-io bazel-io closed this in 73f1ecb Apr 27, 2022
@keith keith deleted the ks/fix-android-emulator-darwin_arm64-select branch April 27, 2022 18:08
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 27, 2022
@ckolli5
Copy link

ckolli5 commented Apr 27, 2022

@bazel-io fork 5.2.0

@bazel-io bazel-io mentioned this pull request Apr 27, 2022
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 27, 2022
@ckolli5 ckolli5 mentioned this pull request May 10, 2022
Merged
ckolli5 added a commit that referenced this pull request May 10, 2022
@ckolli5 @keith
Fix android emulator darwin_arm64 select (#15445)
c8b6496 
This fixes this condition printing a strange error if you try to run
these on macOS. In general this still doesn't work because of
#7069 but if we ever want to
support it this is a pre-requisite to supporting arm macs

Closes #15092.

PiperOrigin-RevId: 444912275

Co-authored-by: Keith Smiley <[email protected]>
meteorcloudy pushed a commit that referenced this pull request May 10, 2022
@ckolli5 @keith @meteorcloudy
Fix android emulator darwin_arm64 select (#15445)
e1ea2a9 
This fixes this condition printing a strange error if you try to run
these on macOS. In general this still doesn't work because of
#7069 but if we ever want to
support it this is a pre-requisite to supporting arm macs

Closes #15092.

PiperOrigin-RevId: 444912275

Co-authored-by: Keith Smiley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ted-xie ted-xie ted-xie approved these changes

@ahumesky ahumesky Awaiting requested review from ahumesky ahumesky is a code owner

Assignees
No one assigned
Labels
team-Android Issues for Android team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keith @ted-xie @brentleyjones @ckolli5 @bazel-io