Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python3 on macOS #15045

Closed
wants to merge 1 commit into from
Closed

Use python3 on macOS #15045

wants to merge 1 commit into from

Conversation

ob
Copy link
Contributor

@ob ob commented Mar 15, 2022

macOS 12.3 removed /usr/bin/python2.7 and /usr/bin/python. We need to use python3 now.

@brentleyjones
Copy link
Contributor

@bazel-io fork 5.1

@bazel-io bazel-io mentioned this pull request Mar 15, 2022
Closed
keith
keith approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@keith keith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a case where the python script is run and this works, the script does not need updates. I didn't catch this in previous testing because we don't have any libraries that hit the slow path of libtool.sh

@sgowroji sgowroji added team-Rules-Python Native rules for Python team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Mar 17, 2022
@kersson
Copy link

kersson commented Mar 17, 2022 •
edited
Loading

Our teams needed additional changes to unblock us: ButterflyNetwork@938c427

We're still on 4.2.2, so that's the base of that commit. We only tested these changes on macOS.

Edit: did more digging and found our changes were already made in #11201. Would be great to get them ported back to 4.x. Any plans to do that? If someone can point me in the right direction (e.g. the right base branch, commit format, etc.), I could stage a PR to do so.

jszumski pushed a commit to jszumski/bazel that referenced this pull request Mar 18, 2022
Cherry pick bazelbuild#15045
a3adeba
jszumski pushed a commit to jszumski/bazel that referenced this pull request Mar 18, 2022
Cherry pick bazelbuild#15045
b0039d3
@Wyverald Wyverald self-assigned this Mar 21, 2022
@Wyverald
Copy link
Member

@googlewalt asks:

Do we need to set LANG="en_US.UTF-8" [on line 81]? When I did the analogous change internally in [Google], not setting LANG gets me these errrors: [redacted]

@keith
Copy link
Member

keith commented Mar 22, 2022

I tested and did not have to set that, without knowing more about the error I'm not sure what conditions that shows up in to repro

@bazel-io bazel-io closed this in 3785677 Mar 22, 2022
brentleyjones pushed a commit to brentleyjones/bazel that referenced this pull request Mar 22, 2022
@ob @brentleyjones
Use python3 on macOS
571965d 
macOS 12.3 removed `/usr/bin/python2.7` and `/usr/bin/python`. We need to use `python3` now.

Closes bazelbuild#15045.

PiperOrigin-RevId: 436548693
(cherry picked from commit 3785677)
Wyverald pushed a commit that referenced this pull request Mar 22, 2022
@brentleyjones @ob
Use python3 on macOS (#15102)
3b2d686 
macOS 12.3 removed `/usr/bin/python2.7` and `/usr/bin/python`. We need to use `python3` now.

Closes #15045.

PiperOrigin-RevId: 436548693
(cherry picked from commit 3785677)

Co-authored-by: Oscar Bonilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith keith keith approved these changes

Assignees

@Wyverald Wyverald

@googlewalt googlewalt

Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website team-Rules-Python Native rules for Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ob @brentleyjones @kersson @Wyverald @keith @sgowroji @googlewalt