Yield a Proxy for addresses without protocol #14897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamawolf Thanks for the PR, have you tested this actually work? @coeuvre Can you also take a look, I don't have much experience with proxy. |
|
@meteorcloudy yes, confirmed this fixes our issue. A couple devs in our company have been using my debug build as their daily-driver and now have no problems with running bazel commands while connected to Proxyman. |
|
@bazel-io fork 5.1 |
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Mar 4, 2022
Addresses bazelbuild#14896 Closes bazelbuild#14897. PiperOrigin-RevId: 431949154 (cherry picked from commit f7d8288)
Wyverald
pushed a commit
that referenced
this pull request
Mar 4, 2022
Addresses #14896 Closes #14897. PiperOrigin-RevId: 431949154 (cherry picked from commit f7d8288) Co-authored-by: Adam Wolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #14896