-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for #13110 #13167
Documentation for #13110 #13167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left one comment, but in general can you please clarify that this is coming from execution platforms, not target platforms?
site/docs/exec-groups.md
Outdated
It is possible to define `exec_properties` for arbitrary execution groups on | ||
platform targets (unlike `exec_properties` set directly on a target, where | ||
properties for unknown execution groups are rejected). Targets then inherit the | ||
platform's `exec_properties` that affect the default execution group and any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Targets then inherit the execution platform's exec_proeprties
"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (here and in one other place) - not sure if it should be made clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this today.
Thank you! |
Closes #13167. PiperOrigin-RevId: 361885312
Closes #13167. PiperOrigin-RevId: 361885312
Closes #13167. PiperOrigin-RevId: 361885312
Closes bazelbuild#13167. PiperOrigin-RevId: 361885312
@katre