Respect Starlark options with values in removeStarlarkOptions()
#12648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: #11301 (Partially fixed in 2ec58f6) Motivation: `StarlarkOptionsParser.removeStarlarkOptions()` doesn't take the case into account where the specified Starlark option has a value, e.g. `--//my_rules/custom_flags:foo=bar`. Modifications: - Do not pass a Starlark flag value when validating the flag name. Result: `bazel info` does not fail anymore when `.bazelrc` contains a statement like the following: build --//my_rules/custom_flags:foo=bar
|
Bump |
|
Thanks a lot @buchgr for helping this PR get merged. 🙇 |
katre
pushed a commit
that referenced
this pull request
Jul 12, 2021
Related: #11301 (Partially fixed in 2ec58f6) Motivation: `StarlarkOptionsParser.removeStarlarkOptions()` doesn't take the case into account where the specified Starlark option has a value, e.g. `--//my_rules/custom_flags:foo=bar`. Modifications: - Do not pass a Starlark flag value when validating the flag name. Result: `bazel info` does not fail anymore when `.bazelrc` contains a statement like the following: build --//my_rules/custom_flags:foo=bar Closes #12648. PiperOrigin-RevId: 348676049
katre
pushed a commit
to katre/bazel
that referenced
this pull request
Jul 13, 2021
Related: bazelbuild#11301 (Partially fixed in bazelbuild@2ec58f6) Motivation: `StarlarkOptionsParser.removeStarlarkOptions()` doesn't take the case into account where the specified Starlark option has a value, e.g. `--//my_rules/custom_flags:foo=bar`. Modifications: - Do not pass a Starlark flag value when validating the flag name. Result: `bazel info` does not fail anymore when `.bazelrc` contains a statement like the following: build --//my_rules/custom_flags:foo=bar Closes bazelbuild#12648. PiperOrigin-RevId: 348676049
katre
pushed a commit
to katre/bazel
that referenced
this pull request
Jul 13, 2021
Related: bazelbuild#11301 (Partially fixed in bazelbuild@2ec58f6) Motivation: `StarlarkOptionsParser.removeStarlarkOptions()` doesn't take the case into account where the specified Starlark option has a value, e.g. `--//my_rules/custom_flags:foo=bar`. Modifications: - Do not pass a Starlark flag value when validating the flag name. Result: `bazel info` does not fail anymore when `.bazelrc` contains a statement like the following: build --//my_rules/custom_flags:foo=bar Closes bazelbuild#12648. PiperOrigin-RevId: 348676049
katre
pushed a commit
to katre/bazel
that referenced
this pull request
Jul 13, 2021
Related: bazelbuild#11301 (Partially fixed in bazelbuild@2ec58f6) Motivation: `StarlarkOptionsParser.removeStarlarkOptions()` doesn't take the case into account where the specified Starlark option has a value, e.g. `--//my_rules/custom_flags:foo=bar`. Modifications: - Do not pass a Starlark flag value when validating the flag name. Result: `bazel info` does not fail anymore when `.bazelrc` contains a statement like the following: build --//my_rules/custom_flags:foo=bar Closes bazelbuild#12648. PiperOrigin-RevId: 348676049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #11301
(Partially fixed in 2ec58f6)
Motivation:
StarlarkOptionsParser.removeStarlarkOptions()doesn't take the caseinto account where the specified Starlark option has a value, e.g.
--//my_rules/custom_flags:foo=bar.Modifications:
Result:
bazel infodoes not fail anymore when.bazelrccontains a statementlike the following: