Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatible_disable_depset_items: disallow the "items" parameter on the depset constructor #9017

Closed
c-parsons opened this issue Jul 30, 2019 · 1 comment
Closed

incompatible_disable_depset_items: disallow the "items" parameter on the depset constructor #9017

c-parsons opened this issue Jul 30, 2019 · 1 comment
Labels
incompatible-change Incompatible/breaking change P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) type: process

Comments

@c-parsons
Copy link
Contributor

c-parsons commented Jul 30, 2019 •
edited
Loading

Flag: --incompatible_disable_depset_items

Disables the items parameter of the depset() contructor.

Motivation

The items parameter has been documented as Deprecated for many months. Users are encouraged to use direct and transitive instead.

Migration

Separate the items of a depset into the direct elements and the transitive depsets to union; use direct and transitive parameters. See the documentation.
@c-parsons c-parsons added team-Starlark incompatible-change Incompatible/breaking change labels Jul 30, 2019
@c-parsons c-parsons self-assigned this Jul 30, 2019
@c-parsons c-parsons changed the title incompatible_disable_depset_inputs: disallow the "inputs" parameter on the depset constructor incompatible_disable_depset_items: disallow the "items" parameter on the depset constructor Jul 30, 2019
bazel-io pushed a commit that referenced this issue Aug 15, 2019
@c-parsons @copybara-github
Disable the items parameter of the depset() contructor.
f0cf2b4 
This is an incompatible change attached to new flag --incompatible_disable_depset_items.

See #9017 for details.

RELNOTES: New incompatible flag --incompatible_disable_depset_items disables the "items" parameter in the Starlark depset constructor. Use "direct" and "transitive" parameters instead.
PiperOrigin-RevId: 263597718
This was referenced Nov 22, 2019
Closed
Closed
@aehlig
Copy link
Contributor

aehlig commented Dec 2, 2019

It seems that this flag isn't flipped yet. Extending the migration window.

This was referenced Dec 26, 2019
Closed
Open
Closed
Closed
Open
Closed
Open
Closed
Closed
Open
Closed
Open
Closed
Open
This was referenced Mar 30, 2020
Merged
Closed
Merged
Open
@brandjon brandjon added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Build-Language and removed team-Starlark labels Feb 19, 2021
amberdixon added a commit to bazel-ios/rules_ios that referenced this issue Nov 16, 2021
@amberdixon
Migrate depset items field, see bazelbuild/bazel#9017
3a6b5a7
@Wyverald Wyverald mentioned this issue Dec 7, 2021
Closed
@jacobbogdanov jacobbogdanov mentioned this issue Mar 16, 2022
Merged
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Disable the items parameter of the depset() contructor.
3cfb178 
    This is an incompatible change attached to new flag --incompatible_disable_depset_items.

    See bazelbuild/bazel#9017 for details.

    RELNOTES: New incompatible flag --incompatible_disable_depset_items disables the "items" parameter in the Starlark depset constructor. Use "direct" and "transitive" parameters instead.
    PiperOrigin-RevId: 263597718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
incompatible-change Incompatible/breaking change P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) type: process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@katre @meisterT @laurentlb @philwo @brandjon @aiuto @aehlig @c-parsons