Stop loading packages in CppConfiguration

[hlopko]

Tracking the effort to finally remove package loading from CppConfigurationLoader and CppConfiguration.

[ob]

Is this going to help with objc_library not loading so many more dependencies than cc_library?

[hlopko]

Nope, it will only help with not loading C++ toolchain in the loading phase, only in the analysis phase (which is a prerequisite for migrating C++ rules to platforms). I'm not sure I know which issue are you referring to?

[ob]

I'm talking about this:

$ cat test.sh 
#!/bin/sh

rm -rf tmp_workspace
mkdir tmp_workspace
touch WORKSPACE
cat > BUILD <<EOF
objc_library(
  name = 'objc',
  srcs = ['a.m'],
)

cc_library(
  name = 'cc',
  srcs = ['a.c'],
)
EOF
# discard output about starting the daemon
bazel version >/dev/null 2>&1

echo objc_library implicit dependencies
bazel query --host_deps --implicit_deps 'deps(//:objc)' | sort >objc_deps
echo cc_library implicit dependencies
bazel query --host_deps --implicit_deps 'deps(//:cc)' | sort >cc_deps
echo objc_lib has `wc -l objc_deps` dependencies
echo cc_lib has `wc -l cc_deps` dependencies
diff -u cc_deps objc_deps

which produces

objc_library implicit dependencies
cc_library implicit dependencies
objc_lib has 577 objc_deps dependencies
cc_lib has 54 cc_deps dependencies

Full output here

[hlopko]

I failed to add the issue number to some of my late commits. Here they come:

• ff7b878
• d37e18e
• 734934d
• 123f3ab
• d37e18e
• 2beb781
• 8fbe252
• 85ebae3
• ed1c01f
• 3aa8079
• 37dc726
• 52b3262

[hlopko]

And with this I declare the issue fixed.