Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - May 2018 - Target RC date: 2018-05-04 - name: 0.14.0 #5056

Closed
dslomov opened this issue Apr 19, 2018 · 71 comments
Closed

Release - May 2018 - Target RC date: 2018-05-04 - name: 0.14.0 #5056

dslomov opened this issue Apr 19, 2018 · 71 comments
Assignees
Labels

Comments

@dslomov
Copy link
Contributor

dslomov commented Apr 19, 2018

No description provided.

@dslomov
Copy link
Contributor Author

dslomov commented Apr 19, 2018

@lfpino lmk if you are not available on these dates

@ajrepp
Copy link

ajrepp commented Apr 19, 2018

@dslomov I believe the title of this issue and #5057, #5058, and #5059 erroneously says "2019" instead of "2018".

@dslomov dslomov changed the title Release - May 2019 - Target RC date: 2018-05-01 - name: 0.14.0 Release - May 2018 - Target RC date: 2018-05-01 - name: 0.14.0 Apr 19, 2018
@dslomov
Copy link
Contributor Author

dslomov commented Apr 19, 2018

Thanks! Fixed.

@lfpino
Copy link
Contributor

lfpino commented Apr 19, 2018

@dslomov, which dates exactly? I will be on vacation from Apr 27 until May 2 (inclusive), so from the issue title I won't be available.

@dslomov
Copy link
Contributor Author

dslomov commented Apr 20, 2018

@lfpino we can change a date to May 3rd (which means you have to work on release the first day after your vacation), or you can swap with someone - see #5057, #5058 for some candidates :)

@dslomov dslomov changed the title Release - May 2018 - Target RC date: 2018-05-01 - name: 0.14.0 Release - May 2018 - Target RC date: 2018-05-04 - name: 0.14.0 Apr 20, 2018
@RNabel
Copy link
Contributor

RNabel commented May 10, 2018

@lfpino Is there an approximate timeline for this release? Just wondering whether this will be pushed back to late May due to the delay in the 0.12/13 releases.

@lfpino
Copy link
Contributor

lfpino commented May 11, 2018

Hello Robin, sorry for the delay. I'm working on creating a new Release candidate (we should have one today or on Monday). On the other hand, the release itself should happen late May. Hope it helps.

@laszlocsomor
Copy link
Contributor

@lfpino : Please ensure the RC contains f96f037. Thanks!

@laszlocsomor
Copy link
Contributor

laszlocsomor commented May 14, 2018

@lfpino : Please ensure the RC contains f96f037. Thanks!

To fix #5125 and #5135.

@lfpino
Copy link
Contributor

lfpino commented May 14, 2018

I've created 0.14.0rc1 with baseline 5c3f5c9 and cherrypicked f96f037. The tests are running in https://buildkite.com/bazel/release/builds/40.

@lfpino
Copy link
Contributor

lfpino commented May 14, 2018

@lfpino
Copy link
Contributor

lfpino commented May 15, 2018

The Windows related failures are tracked in #5125.

The failures in rules_python seem to be unrelated to Bazel since the test is failing with 0.12 and 0.13 too, I've reported them there: bazelbuild/rules_python#98

@aehlig
Copy link
Contributor

aehlig commented May 15, 2018

If we create another rc, can be please also cherry-pick ff8162d to keep FreeBSD a known platform? Thanks.

@laszlocsomor
Copy link
Contributor

Klaus, we don't need to. The shell toolchain is not yet in use.
In fact, I just learned from @gregestren that leaving the exec_compatible_with list empty makes the toolchain compatible with everything -- I'll update the documentation about that.

@aehlig
Copy link
Contributor

aehlig commented May 15, 2018

Klaus, we don't need to. The shell toolchain is not yet in use.

We still need the cherry-pick (or I have to locally patch it in the port); even if the shell toolchain is not yet used, sh_configure.bzl is still executed and fails the build with "Unknown OS".

@laszlocsomor
Copy link
Contributor

In that case, would you accept waiting for a patch that removes the exec_compatible_with altogether, and cherrypicking that instead?

@laszlocsomor
Copy link
Contributor

@aehlig : Before I start working on such a patch, could you please try if you can bootstrap on FreeBSD if you remove the exec_compatible_with altogether?

@aehlig
Copy link
Contributor

aehlig commented May 16, 2018 via email

@laszlocsomor
Copy link
Contributor

@aehlig : Thank you! Would you mind creating a PR for this patch and requesting to cherrypick that?

@aehlig
Copy link
Contributor

aehlig commented May 16, 2018 via email

laszlocsomor pushed a commit to laszlocsomor/bazel that referenced this issue May 16, 2018
Since that restriction is not necessary at the moment, we can as well
not compute it in the first place.

Potentially to be cherry-picked for 0.14.0, see bazelbuild#5056.

Change-Id: Ic2d4ec1b037ce464e85e243b69bedd483bc515ac
@laszlocsomor
Copy link
Contributor

No, I meant a standalone patch based directly on master, and cherry-picking that into the release branch.
I just created it: #5210

@laszlocsomor
Copy link
Contributor

Ah, I missed the whole point. Yes, we need ff8162d otherwise https://bazel-review.googlesource.com/c/bazel/+/56270 cannot be cherrypicked cleanly.

@davido
Copy link
Contributor

davido commented May 28, 2018

Can we cherry-pick bd7db6a? This is a fix for regression from: 88a0072 in 0.13.0 and 0.13.1 and Error Prone integration is broken, see #5134 and #5278.

@lfpino
Copy link
Contributor

lfpino commented May 28, 2018

Hi @davido I've confirmed with @iirina that this is a regression. I'll create another candidate.

@ulfjack
Copy link
Contributor

ulfjack commented May 28, 2018

@lfpino - that commit is not merged yet. It's waiting for @buchgr to review.

@ulfjack
Copy link
Contributor

ulfjack commented May 28, 2018

Link to pull request: #5156

@petemounce
Copy link
Contributor

Catching up - published 0.14.0-rc1 through rc4.

@lfpino
Copy link
Contributor

lfpino commented May 28, 2018

Thanks for the merge @buchgr I'll create a new candidate (rc5) with the additional cherrypick eca7b81

@lfpino
Copy link
Contributor

lfpino commented May 28, 2018

@lfpino
Copy link
Contributor

lfpino commented May 28, 2018

All looks green. We should be able to release release-0.14.0rc5 on Wednesday.

@lfpino
Copy link
Contributor

lfpino commented May 30, 2018

I didn't manage to get to this today. The release will happen on Friday. Sorry for the delay.

@lfpino
Copy link
Contributor

lfpino commented Jun 1, 2018

Pushed release:
https://github.com/bazelbuild/bazel/releases/tag/0.14.0
https://releases.bazel.build/0.14.0/release/index.html

@petemounce : Could you please update Chocolatey? Thanks!
@ilovezfs : Could you please update Homebrew? Thanks!

@ilovezfs
Copy link
Contributor

ilovezfs commented Jun 1, 2018

@lfpino
Copy link
Contributor

lfpino commented Jun 1, 2018

Thank you @ilovezfs !

@ilovezfs
Copy link
Contributor

ilovezfs commented Jun 1, 2018

You're welcome. 0.14.0 shipped in Homebrew.

@lfpino lfpino closed this as completed Jun 1, 2018
@lberki
Copy link
Contributor

lberki commented Jun 6, 2018

Given that 0.14 is affected by #5336 and it's a pretty serious issue, essentially making Bazel potentially unusable on machines where Docker isn't in a good shape (and running docker info on every build is questionable at best anyway), I propose that we do a patch release with that change included. @lfpino , what do you think?

@dslomov
Copy link
Contributor Author

dslomov commented Jun 6, 2018

+1 to patch release

@lfpino
Copy link
Contributor

lfpino commented Jun 6, 2018

I'll create a patch release tomorrow.

@jmillikin-stripe
Copy link
Contributor

@lfpino could I ask for the patch release to include #5338 also? Changes to the disk cache flags from 0.13->0.14 caused a regression in how remote execution flags are validated.

@dslomov
Copy link
Contributor Author

dslomov commented Jun 6, 2018

Hmm does #5308 warrant a patch release?

@dslomov
Copy link
Contributor Author

dslomov commented Jun 7, 2018

Since #5308 is not resolved yet, I suggets we create a 0.14.1 with just a fix for #5336

@ulfjack
Copy link
Contributor

ulfjack commented Jun 7, 2018

@dslomov, it's not resolved yet because you didn't import the patch yet. I just sent you the import.

@dslomov
Copy link
Contributor Author

dslomov commented Jun 7, 2018

@ulfjack I know but there is also a discussion on #5308 on whether that is the right fix.

@ulfjack
Copy link
Contributor

ulfjack commented Jun 7, 2018

I replied on the bug - I think we should merge the currently proposed fix, and cherrypick it.

@laszlocsomor
Copy link
Contributor

@alexeagle from Angular is reporting memory regressions with 0.14.1: https://groups.google.com/d/msg/bazel-discuss/SOHd4FWX-6Q/rX7-3uQ5BAAJ

We should investigate and potentially roll out a 0.14.2 patch release.

@laszlocsomor
Copy link
Contributor

Related bugs: #3645, #5389.

@lfpino lfpino assigned dslomov and lfpino and unassigned lfpino Jun 14, 2018
@lfpino
Copy link
Contributor

lfpino commented Jun 14, 2018

@dslomov can you please take a look since you handled 0.14.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests