Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows, testing: make //src/test/shell/... run on Windows #4930

Closed
laszlocsomor opened this issue Mar 28, 2018 · 9 comments
Closed

Windows, testing: make //src/test/shell/... run on Windows #4930

laszlocsomor opened this issue Mar 28, 2018 · 9 comments
Labels
area-Windows Windows-specific issues and feature requests P3 We're not considering working on this, but happy to review a PR. (No assignee) platform: windows stale Issues or PRs that are stale (no activity for 30 days) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: feature request

Comments

@laszlocsomor
Copy link
Contributor

Blocked by:

Blocking:
@laszlocsomor laszlocsomor self-assigned this Mar 28, 2018
@laszlocsomor laszlocsomor added type: feature request P1 I'll work on this now. (Assignee required) platform: windows labels Mar 28, 2018
@laszlocsomor laszlocsomor mentioned this issue Mar 28, 2018
Closed
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 26, 2018
@laszlocsomor
tests,shell: enable some shell tests on Windows
689c31a 
In this commit:
- split //src/test/shell:shell_utils_test into a
  symlink-specific part and the rest
- use the Bash runfiles library
- add "windows_tests" and "all_windows_tests"
  targets as we do in other platforms (e.g. in
  //src:BUILD)

See bazelbuild#4930
See bazelbuild#4292

Change-Id: I111a7fed223f1f9b767dc6411389465f8da3e043
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 26, 2018
@laszlocsomor
tests,shell: enable some shell tests on Windows
1d57b12 
In this commit:
- split //src/test/shell:shell_utils_test into a
  symlink-specific part and the rest
- use the Bash runfiles library
- add "windows_tests" and "all_windows_tests"
  targets as we do in other platforms (e.g. in
  //src:BUILD)

See bazelbuild#4930
See bazelbuild#4292

Change-Id: I111a7fed223f1f9b767dc6411389465f8da3e043
bazel-io pushed a commit that referenced this issue Apr 26, 2018
@laszlocsomor
tests,shell: enable some shell tests on Windows
a7f202c 
In this commit:
- split //src/test/shell:shell_utils_test into a
  symlink-specific part and the rest
- use the Bash runfiles library
- add "windows_tests" and "all_windows_tests"
  targets as we do in other platforms (e.g. in
  //src:BUILD)

See #4930
See #4292

Change-Id: I111a7fed223f1f9b767dc6411389465f8da3e043
PiperOrigin-RevId: 194395011
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 27, 2018
@laszlocsomor
tests,Windows: run //s/t/shell/bazel:location_test
7b5c7ad 
Use the new Bash runfiles library (for now from
//tools/bash/runfiles, later from
@bazel_tools//tools/bash/runfiles) in testenv.sh,
integration_test_setup.sh, and location_test.sh.

Add missing runfiles that tests were using, such
as //:WORKSPACE.

Enable //src/test/shell/bazel:location_test on
Windows.

See bazelbuild#4930
See bazelbuild#4292

Change-Id: Ib66e96fe73281deabafa6578fb8681d70cd8665b
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Apr 27, 2018
@laszlocsomor
tests: use rlocation in shell tests
5db3e59 
Use the new Bash runfiles library (for now from
//tools/bash/runfiles, later from
@bazel_tools//tools/bash/runfiles) in:
- //src/test/shell:testenv.sh
- //src/test/shell:integration_test_setup.sh
- //src/test/shell/bazel:location_test.sh

This will let us enable location_test on Windows.
(Currently it fails, I'll fix it in a subsequent
commit.)

Add missing runfiles that tests were using, such
as //:WORKSPACE.

See bazelbuild#4930
See bazelbuild#4292

Change-Id: Ib66e96fe73281deabafa6578fb8681d70cd8665b
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue May 2, 2018
@laszlocsomor
tests: use rlocation in shell tests
14c8497 
Use the new Bash runfiles library (for now from
//tools/bash/runfiles, later from
@bazel_tools//tools/bash/runfiles) in:
- //src/test/shell:testenv.sh
- //src/test/shell:integration_test_setup.sh
- //src/test/shell/bazel:location_test.sh

This will let us enable location_test on Windows.
(Currently it fails, I'll fix it in a subsequent
commit.)

Add missing runfiles that tests were using, such
as //:WORKSPACE.

See bazelbuild#4930
See bazelbuild#4292

Change-Id: Ib66e96fe73281deabafa6578fb8681d70cd8665b
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue May 2, 2018
@laszlocsomor
tests: use rlocation in shell tests
7a743c7 
Use the new Bash runfiles library (for now from
//tools/bash/runfiles, later from
@bazel_tools//tools/bash/runfiles) in:
- //src/test/shell:testenv.sh
- //src/test/shell:integration_test_setup.sh
- //src/test/shell/bazel:location_test.sh

This will let us enable location_test on Windows.
(Currently it fails, I'll fix it in a subsequent
commit.)

Add missing runfiles that tests were using, such
as //:WORKSPACE.

See bazelbuild#4930
See bazelbuild#4292

Change-Id: Ib66e96fe73281deabafa6578fb8681d70cd8665b
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue May 2, 2018
@laszlocsomor
tests: use rlocation in one shell test
b480993 
Use the new Bash runfiles library (for now from
//tools/bash/runfiles, later from
@bazel_tools//tools/bash/runfiles) in:
- //src/test/shell:testenv.sh
- //src/test/shell:integration_test_setup.sh
- //src/test/shell/bazel:location_test.sh

Also enable this test on Windows.

Add missing runfiles that tests were using, such
as //:WORKSPACE.

See bazelbuild#4930
See bazelbuild#4292

Change-Id: Ib66e96fe73281deabafa6578fb8681d70cd8665b
@laszlocsomor laszlocsomor mentioned this issue May 2, 2018
Closed
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue May 2, 2018
@laszlocsomor
tests: use rlocation in one shell test
3f3e0ed 
Use the new Bash runfiles library (for now from
//tools/bash/runfiles, later from
@bazel_tools//tools/bash/runfiles) in:
- //src/test/shell:testenv.sh
- //src/test/shell:integration_test_setup.sh
- //src/test/shell/bazel:location_test.sh

Also enable this test on Windows.

Add missing runfiles that tests were using, such
as //:WORKSPACE.

See bazelbuild#4930
See bazelbuild#4292

Change-Id: Ib66e96fe73281deabafa6578fb8681d70cd8665b
@laszlocsomor
Copy link
Contributor Author

Update: I'm still working on this and P1 is appropriate.

laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Jun 13, 2018
@laszlocsomor
Use Bash runfiles library in one shell test.
0b26cb3 
See bazelbuild#4930

Change-Id: I148c0b1e4baa8ff44d86a6ee196bea7e9058320f
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Jun 13, 2018
@laszlocsomor
Use Bash runfiles library in one shell test.
4bafd78 
See bazelbuild#4930

Change-Id: I148c0b1e4baa8ff44d86a6ee196bea7e9058320f
@laszlocsomor laszlocsomor mentioned this issue Jun 13, 2018
Closed
bazel-io pushed a commit that referenced this issue Jun 14, 2018
@laszlocsomor
shell,tests: use Bash runfiles library in one test
2bcf7cd 
See #4930

Change-Id: I148c0b1e4baa8ff44d86a6ee196bea7e9058320f

Closes #5387.

Change-Id: Iba32f21ff6cad1b538c72cfd08ce24846843c124
PiperOrigin-RevId: 200554084
ArielleA pushed a commit to ArielleA/bazel that referenced this issue Jun 19, 2018
@laszlocsomor @ArielleA
shell,tests: use Bash runfiles library in one test
f9a44aa 
See bazelbuild#4930

Change-Id: I148c0b1e4baa8ff44d86a6ee196bea7e9058320f

Closes bazelbuild#5387.

Change-Id: Iba32f21ff6cad1b538c72cfd08ce24846843c124
PiperOrigin-RevId: 200554084
@laszlocsomor
Copy link
Contributor Author

laszlocsomor commented Jul 3, 2018 •
edited
Loading

Current status (at 20637b7):

  • bazel query "tests(//src/test/shell/...)" | wc -l --> 113
  • bazel query "tests(//src/test/shell/...)-tests(//src/test/shell:all_windows_tests)" | wc -l --> 105

Currently only 7% of //src/test/shell/... runs on Windows.

werkt pushed a commit to werkt/bazel that referenced this issue Aug 2, 2018
@laszlocsomor
shell,tests: use Bash runfiles library in one test
713f923 
See bazelbuild#4930

Change-Id: I148c0b1e4baa8ff44d86a6ee196bea7e9058320f

Closes bazelbuild#5387.

Change-Id: Iba32f21ff6cad1b538c72cfd08ce24846843c124
PiperOrigin-RevId: 200554084
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Dec 6, 2018
@laszlocsomor
Windows, tests: port java_integration_test
a1f62d0 
//src/test/shell/integration:java_integration_test
now works on Windows.

See bazelbuild#4930
@laszlocsomor laszlocsomor added P3 We're not considering working on this, but happy to review a PR. (No assignee) area-Windows Windows-specific issues and feature requests and removed P1 I'll work on this now. (Assignee required) labels Feb 28, 2019
@laszlocsomor
Copy link
Contributor Author

Would be nice to have, but not critical, hence P3.

@meisterT
Copy link
Member

The numbers from above comment have changed to
184 vs 115, so 37% run on Windows

@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 2.5 years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Mar 16, 2023
@github-actions
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2023
@fmeum
Copy link
Collaborator

fmeum commented Mar 31, 2023

@bazelbuild/triage This is still relevant to improve the stability of existing features on Windows.

@sgowroji sgowroji removed the stale Issues or PRs that are stale (no activity for 30 days) label Mar 31, 2023
@sgowroji sgowroji reopened this Mar 31, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jun 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please post @bazelbuild/triage in a comment here and we'll take a look. Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Windows Windows-specific issues and feature requests P3 We're not considering working on this, but happy to review a PR. (No assignee) platform: windows stale Issues or PRs that are stale (no activity for 30 days) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@meisterT @philwo @fmeum @laszlocsomor @sgowroji