Skip to content

Commit

Permalink
undo flag flip of --incompatible_strict_action_env
Browse files Browse the repository at this point in the history
it breaks local execution users. we'll need some more time to figure out a better solution that works for both remote and local execution.

RELNOTES: The default value for --incompatible_strict_action_env has been flipped to 'false' again, as we discovered breakages for local execution users. We'll need some more time to figure out the best way to make this work for local and remote execution. Follow #7026 for more details.
PiperOrigin-RevId: 229917346
  • Loading branch information
buchgr authored and Copybara-Service committed Jan 18, 2019
1 parent 0b66fdc commit 9137fb9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public static class StrictActionEnvOptions extends FragmentOptions {
@Option(
name = "incompatible_strict_action_env",
oldName = "experimental_strict_action_env",
defaultValue = "true",
defaultValue = "false",
documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {
Expand Down
4 changes: 2 additions & 2 deletions src/test/shell/bazel/bazel_test_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,11 @@ EOF

# We don't just use the local PATH, but use the test's PATH, which is more restrictive.
PATH=$PATH:$PWD/scripts bazel --nomaster_bazelrc test //testing:t1 -s --run_under=hello \
--test_output=all >& $TEST_log && fail "Expected failure"
--test_output=all --incompatible_strict_action_env=true >& $TEST_log && fail "Expected failure"

# With --action_env=PATH, the local PATH is forwarded to the test.
PATH=$PATH:$PWD/scripts bazel test //testing:t1 -s --run_under=hello \
--test_output=all --action_env=PATH >& $TEST_log || fail "Expected success"
--test_output=all >& $TEST_log || fail "Expected success"
expect_log 'hello script!!! testing/t1'

# We need to forward the PATH to make it work.
Expand Down

0 comments on commit 9137fb9

Please sign in to comment.