Skip to content

Commit

Permalink
Re-add Guava to Bazel TestRunner
Browse files Browse the repository at this point in the history
It was removed in d6ad383. Accidentally, this is a breaking change, because Guava is incorrectly added from TestRunner to Java library.

Breaking change is preventing java_tools to be released and cherry-picked onto Bazel 6.2.0

I tested this manually on one of the downstream breakages.

PiperOrigin-RevId: 525697087
Change-Id: Ic4ade4398ea422d982fe0fe96d2854ef5aeae568
  • Loading branch information
comius authored and copybara-github committed Apr 20, 2023
1 parent 0d672f3 commit 2abff94
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ java_library(
"BazelTestRunner.java",
],
deps = [
# Testrunner shouldn't be added to compile-time deps of java_library.
# Because of this removing Guava dependecy is a breaking change.
# TODO(b/113524892): Short time before Bazel LTS 7 is cut, remove Guava and release java_tools
"//third_party:guava", # build_cleaner: keep
"//src/java_tools/junitrunner/java/com/google/testing/junit/runner/internal",
"//src/java_tools/junitrunner/java/com/google/testing/junit/runner/junit4",
],
Expand Down

0 comments on commit 2abff94

Please sign in to comment.