Add support for spaces and newlines in runfiles paths #4136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzhp
approved these changes
Oct 10, 2024
In Bazel 8.0.0 since bazelbuild/bazel@7407cef.
fmeum
force-pushed
the
spaces-in-runfiles
branch
from
6f434fd to
5d6f695
Compare
github-merge-queue bot
pushed a commit
to bazelbuild/rules_python
that referenced
this pull request
Nov 28, 2024
…#2456) Bazel 7.4.0 introduced support for all characters in runfile source and target paths: bazelbuild/bazel#23912 This is a backwards-compatible change, based on a similar change in rules_go: bazel-contrib/rules_go#4136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
In Bazel 8.0.0 since bazelbuild/bazel@7407cef.
Which issues(s) does this PR fix?
Fixes #
Other notes for review