Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vendor package translations handling #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saarma
Copy link

@saarma saarma commented Sep 7, 2018

Problem

Currently while importing published vendor package the translations will not include the file names. So in the ltm_translations table the group column shows 'vendor/myPackage'.

Also when trying to export the translations, it'll try to export them in wrong folder.

For example:

  1. Importing file from lang/vendor/myPackage/en/file.php
  2. Group column in ltm_translations will be vendor/myPackage
  3. Exporting will try to update translation in path lang/vendor/myPackage/en/en/vendor/myPackage.php

Solution

This fix will include file name to group column and when exporting translations it will export them to the right paths. e.g.

  1. Importing file from lang/vendor/myPackage/en/file.php
  2. Group column in ltm_translations will be vendor/myPackage/file
  3. Exporting will try to update translation in path lang/vendor/myPackage/en/file.php

kritsot added a commit to kritsot/laravel-translation-manager that referenced this pull request Apr 9, 2020
@vytsci
Copy link

vytsci commented May 8, 2020

Same issue here. Path is being built incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants