Created a positiblity to add custom relation type

[efinder2]

In a project of mine I use the eloquent-has-many-deep library. To enable the ide-helper for it, I wrote a possibility to add a config option to add custom relation types.

I know the code isn't tested yet. I'll add it as soon as the idea of the pull request has been discussed.

[mfn]

IMHO looks good to move forward with tests

Thanks :)

[mr-feek]

Is this something we can/should solve via reflection? Perhaps that is difficult, though. We would need to search through each method, and see if the return type is a subtype of Relation. What do we think? I might be willing to take a stab at it!

[efinder2]

It might not be the perfect solution at the moment. Not all code uses a strict return type. The linked library for example hasn't implemented them yet, so reflection might be a great addition to get rid of the mapping for types methods. As fallback I suggest to keep the config option

[mfn]

Personally I would reduce the time invested, the config approach seems a pragmatic approach. I bet it doesn't come up often. First time I hear about this requirement in years 😄

[efinder2]

I've looked into the source from Laravel. The relations don't have a return type. So the reflection would need Parsing of the return type of the doc block. This isn't ideal.

[efinder2]

Only Problem I see in the config approach, may be two libraries modifying the config. For future extension it might be helpful to create a HelperClass for adding class mappings to the config property.
I've also added a test for the change.

Please review the Test. I'm not sure everything is covert.

[mfn]

@barryvdh LGTM!

[mfn]

@efinder2 I took the liberty and updated the PR with master, applied my own feedback and added a changelog entry

@barryvdh IMHO this is good to merge!

[barryvdh]

Hmm it has conflicts again

[mfn]

@barryvdh fixed!

We'll likely see this more often now with the changelog, adding entries at the top I fear…