-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make writing relation count properties optional #837
Make writing relation count properties optional #837
Conversation
I am interested in this configuration too. Same as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. A clean and simple improvement!
config/ide-helper.php
Outdated
| If set to true, every "x to many" relation will generate an accompanying | ||
| "$relation_count" property DocBlock comment. | ||
| | ||
| If set to false, no such DocBlock comments will be generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a bit redundant, i think the description is long and clear enough without this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second this, please remove it
@barryvdh Any chance to get this merged? |
Is this repo still maintained? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be useful addition 👍
Even better if you could add a test!
config/ide-helper.php
Outdated
| If set to true, every "x to many" relation will generate an accompanying | ||
| "$relation_count" property DocBlock comment. | ||
| | ||
| If set to false, no such DocBlock comments will be generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second this, please remove it
Am I right in assuming that the missing test is the only thing, that prevents this PR from being merged? |
@PaulRotter I'm not the ultimate decision make here, but it's my believe that changes/added features should be accompanied with tests showing they work as intended. I therefore made sure that, especially the ModelsCommand, can be tested and added an initial batch of tests so others can follow more easily; you should find enough examples to make a test and it shouldn't take you longer than the the actual implementation. Personally I don't see anything (else) in the way of merging this. |
#783 introduced writing of DocBlock comments for
$relation_count
properties, populated bywithCount
/loadCount
. This makes writing those comments optional and configurable (still on by default).