Add support for nikic/php-parser:^5 and (hopefully) doctrine/dbal:^4 #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `createForHostVersion` has been added to php-parse 4.18 so code can run with both versions [1] - therefore also bumped the minimum required version to it Note: The dev dependency vimeo/psalm is **not** compatible with php-parser:^5 currently. This does not impact usages of this library, but sometimes cause friction when working on this library. For our CI this isn't a problem, because we already remove that dependency before running the test suite. [1] https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-5.0.md#changes-to-the-parser-factory
mfn
commented
Jan 27, 2024
| @@ -17,6 +17,7 @@ jobs: | |||
| env: | |||
| COMPOSER_NO_INTERACTION: 1 | |||
| strategy: | |||
| fail-fast: false | |||
There was a problem hiding this comment.
I needed this because we had multiple failed integration tests and I needed this to better understand the pattern which ones specifically failed. Eventually I decided to leave it in, in case of failures it's more useful to see all failed ones.
Comment on lines
-28
to
-29
| - php: 7.4 | ||
| laravel: 10.* |
There was a problem hiding this comment.
Duplicate entry 🤷🏼 => removed
Comment on lines
+31
to
+40
| - php: 8.3 | ||
| laravel: 9.* | ||
| - php: 7.4 | ||
| laravel: 9.* | ||
| - php: 7.3 | ||
| laravel: 9.* | ||
| - php: 8.3 | ||
| laravel: 8.* | ||
| - php: 8.2 | ||
| laravel: 8.* |
There was a problem hiding this comment.
These are officially not supported
mfn
changed the title
barryvdh
approved these changes
Jan 28, 2024
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
…arryvdh#1502) * Add support for nikic/php-parser:^5 - `createForHostVersion` has been added to php-parse 4.18 so code can run with both versions [1] - therefore also bumped the minimum required version to it Note: The dev dependency vimeo/psalm is **not** compatible with php-parser:^5 currently. This does not impact usages of this library, but sometimes cause friction when working on this library. For our CI this isn't a problem, because we already remove that dependency before running the test suite. [1] https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-5.0.md#changes-to-the-parser-factory * gha: prevent cancelling of all jobs if one fails * Update CHANGELOG.md * gha: remove unsupported Laravel / PHP combinations According to https://laravel.com/docs/10.x/releases * Add dbal:^4 too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
createForHostVersionhas been added to php-parser 4.18 so code can run with both versions [1]However, unrelated some tests in
masterwere not working currently, which I also fixed to get the ✅ :This solved some combination of the integration tests failing, though I'm not 100% sure if dbal truly works with it; it seems none of the feature tests install it and it has no stable release yet 🤔
Fixes #1498 and #1490
Notes
[1] https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-5.0.md#changes-to-the-parser-factory
Type of change
Checklist
composer fix-style