New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid phpdoc for casted property without return (#1236) #1264

Open

edgardmessias wants to merge 1 commit into barryvdh:master from edgardmessias:fix_1236

edgardmessias commented Oct 7, 2021

Summary

Fix invalid phpdoc for casted property without return type

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist

Existing tests have been adapted and/or new tests have been added
Add a CHANGELOG.md entry
Update the README.md
Code style has been fixed via composer fix-style


          Fix invalid phpdoc for casted property without return (barryvdh#1236)

d746023

mfn requested changes

View reviewed changes

Collaborator

mfn left a comment

I think we've good coverage and test-ability for this code in general, do you think you can add a test showing this?

Author

edgardmessias commented Oct 12, 2021

Yes, I can try add some test for this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet