-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto generate models #1163
Merged
Merged
Auto generate models #1163
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9c80ac2
Add illuminate/events as suggestion
netpok 3d84994
Add post migration to config
netpok e0459e6
Add listener to generate model helper
netpok 414f483
Add event listeners if enabled
netpok 57f5705
Fix config file format
netpok 88156e0
Add docblock for shouldRun flag
netpok 7bbf3bd
Allow running multiple commands after migrations
netpok c955afb
Simplify config
netpok e98dcd2
Change default value
netpok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
<?php | ||
|
||
namespace Barryvdh\LaravelIdeHelper\Listeners; | ||
|
||
use Illuminate\Console\Events\CommandFinished; | ||
use Illuminate\Contracts\Config\Repository as Config; | ||
use Illuminate\Contracts\Console\Kernel as Artisan; | ||
|
||
class GenerateModelHelper | ||
{ | ||
/** @var bool */ | ||
public static $shouldRun = false; | ||
|
||
/** @var \Illuminate\Contracts\Console\Kernel */ | ||
protected $artisan; | ||
|
||
/** @var \Illuminate\Contracts\Config\Repository */ | ||
protected $config; | ||
|
||
/** | ||
* @param \Illuminate\Contracts\Console\Kernel $artisan | ||
* @param \Illuminate\Contracts\Config\Repository $config | ||
*/ | ||
public function __construct(Artisan $artisan, Config $config) | ||
{ | ||
$this->artisan = $artisan; | ||
$this->config = $config; | ||
} | ||
|
||
/** | ||
* Handle the event. | ||
* | ||
* @param CommandFinished $event | ||
*/ | ||
public function handle(CommandFinished $event) | ||
{ | ||
if (!self::$shouldRun) { | ||
return; | ||
} | ||
|
||
self::$shouldRun = false; | ||
mfn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
$parameters = $this->config->get('ide-helper.post_migrate'); | ||
$this->artisan->call( | ||
is_array($parameters) ? 'ide-helper:models' : 'ide-helper:models ' . $parameters, | ||
is_array($parameters) ? $parameters : [], | ||
$event->output, | ||
); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the other change and the clarification! I think for consistency, we also should default to
[]
here now:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought leaving this as false since its a condition but ok, changed it.
Oh, I could have just accepted the change here...