Allow for PhpDoc for macros with union types #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
reviewed
Mar 12, 2021
| $type = $this->concatReflectionTypes($reflectionType); | ||
|
|
||
| /** @psalm-suppress UndefinedClass */ | ||
| if ($reflectionType && !$reflectionType instanceof \ReflectionUnionType && $reflectionType->allowsNull()) { |
There was a problem hiding this comment.
\ReflectionUnionType
I assume in PHP < 8 this will "just work", because a non-existent class check in instanceof will not trigger any problems?
|
Is there anything left to do before merging? We're currently using the patch branch in our project since this bug was breaking the ide-helper package. Thanks! |
|
@mfn you haven't approved this, but did say LGTM so I guess it's okay with you :) |
|
Thanks for merging! |
|
The last release was on April 9th. When will this fix be released? I dont want to use |
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
* Allow for PhpDoc for macros with union types * Replace null coalescing operator * Test init PhpDoc for macros with parameter union types * Allow for PhpDoc for macros with union return types * Add helper method to Macro class * Add changelog entry * Format * Complement changelog with PR link * Add missing return * Fix test for PHP < 8 * Rewrite PHP 8 test using eval() * Remove obsolete test class * Suppress Psalm errors for undefined ReflectionUnionType class * Remove unreachable return statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running the IDE helper on macros with PHP 8 union types, an error
Call to undefined method ReflectionUnionType::getName()will be thrown. This PR aims to fix that for both the parameter and return types.Type of change
Checklist
composer fix-style