Macro::initPhpDoc() will save original docblock if present.
#1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barryvdh
approved these changes
Dec 21, 2020
LastDragon-ru
force-pushed
the
issue-1099
branch
from
1b578e3 to
b06a7fd
Compare
mfn
approved these changes
Dec 23, 2020
bytestream
pushed a commit
to bytestream/laravel-ide-helper
that referenced
this pull request
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The #1006 added support for macros but lost the content of the original docblock that was useful to provide an actual description, params, and return types. This PR fixes it:
@params will be added only when the original docblock doesn't have them@returnwill be added only when the original docblock doesn't have itFixes #1099
Type of change
Checklist