Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

pyband: Auth module implementation #2588

Merged
merged 8 commits into from
Sep 14, 2020
Merged

pyband: Auth module implementation #2588

merged 8 commits into from
Sep 14, 2020

Conversation

taobun
Copy link
Member

@taobun taobun commented Aug 30, 2020

Fixed: #2531

Implementation details

  • Verify msg from public key.
  • Check request status from chian.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@render
Copy link

render bot commented Aug 30, 2020

from .wallet import PublicKey
from .data import Request, RequestInfo

REQUET_DURATION = 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@@ -44,6 +44,7 @@

### Helpers

- (feat) [\#2588](https://github.com/bandprotocol/bandchain/pull/2577) pyband: Auth module implementation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 2588, not 2577.

@taobun taobun merged commit c494fb7 into master Sep 14, 2020
@taobun taobun deleted the auth-module branch September 14, 2020 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyband auth module specification
3 participants