This repository has been archived by the owner on Nov 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://d3n-scan-pr-2588.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-bt5viqn93em3np938qt0. |
sorawit
suggested changes
Aug 31, 2020
helpers/pyband/pyband/auth.py
Outdated
from .wallet import PublicKey | ||
from .data import Request, RequestInfo | ||
|
||
REQUET_DURATION = 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
evilpeach
reviewed
Sep 2, 2020
CHANGELOG_UNRELEASED.md
Outdated
@@ -44,6 +44,7 @@ | |||
|
|||
### Helpers | |||
|
|||
- (feat) [\#2588](https://github.com/bandprotocol/bandchain/pull/2577) pyband: Auth module implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 2588, not 2577.
sorawit
approved these changes
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #2531
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.md
Files changed
tab in the Github PR explorer)