Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Implemented the new layout for Validator Homepage #2561

Merged
merged 3 commits into from
Aug 25, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Aug 25, 2020

Fixed: #2535

Implementation details

  • Applied the new layout to the validator homepage on both Desktop and mobile screen.
  • Cleaned code by separating the components:
    • Moved UptimeBar to Progressbar.Uptime
    • Removed SortableDropdown in the file and used the reuseable SortableDropdown instead.
    • Remake ToggleButton component
  • Changed Body BG to gray and also updated it on the Homepage section

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach August 25, 2020 10:25
@render
Copy link

render bot commented Aug 25, 2020

@pzshine pzshine force-pushed the revamp-validator-homepage branch from cbd675c to 1533fac Compare August 25, 2020 10:31
scan/src/pages/ValidatorHomePage.re Outdated Show resolved Hide resolved
scan/src/components/ValidatorsTable.re Outdated Show resolved Hide resolved
@pzshine pzshine merged commit ed2e697 into master Aug 25, 2020
@pzshine pzshine deleted the revamp-validator-homepage branch August 25, 2020 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GuanYu revamp - Validator Home Page
2 participants