Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

yoda: Remove option docker executor #2463

Merged
merged 3 commits into from
Aug 13, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG_UNRELEASED.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

### Yoda

- (impv) [\#2463](https://github.com/bandprotocol/bandchain/pull/2463) Remove docker from executor option.

### Emitter & Flusher

- (impv) [\#2453](https://github.com/bandprotocol/bandchain/pull/2453) Add index to improve graphql performance
Expand Down
2 changes: 1 addition & 1 deletion chain/docker-config/start_docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ do
yoda config node tcp://172.18.0.1$v:26657
yoda config chain-rest-server http://172.18.0.20:1317
yoda config validator $(bandcli keys show validator$v -a --bech val --keyring-backend test)
yoda config executor "rest:https://3hdt5gnbr6.execute-api.ap-southeast-1.amazonaws.com/live/py-execution"
yoda config executor "rest:https://3hdt5gnbr6.execute-api.ap-southeast-1.amazonaws.com/live/py-execution?timeout=10s"

# activate validator
echo "y" | bandcli tx oracle activate --from validator$v --keyring-backend test
Expand Down
2 changes: 1 addition & 1 deletion chain/scripts/start_yoda.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ yoda config chain-id bandchain
yoda config validator $(bandcli keys show $1 -a --bech val --keyring-backend test)

# setup execution endpoint
yoda config executor "docker:bandprotocol/runtime:1.0.2?timeout=10s"
yoda config executor "rest:https://3hdt5gnbr6.execute-api.ap-southeast-1.amazonaws.com/live/py-execution?timeout=10s"

# setup broadcast-timeout to yoda config
yoda config broadcast-timeout "30s"
Expand Down
2 changes: 1 addition & 1 deletion chain/yoda/executor/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func NewExecutor(executor string) (Executor, error) {
case "rest":
return NewRestExec(base, timeout), nil
case "docker":
return NewDockerExec(base, timeout), nil
return nil, fmt.Errorf("Docker does not support for current Yoda version")
Benzbeeb marked this conversation as resolved.
Show resolved Hide resolved
default:
return nil, fmt.Errorf("Invalid executor name: %s, base: %s", name, base)
}
Expand Down