Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Implement full copy non evm proof #2455

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Implement full copy non evm proof #2455

merged 2 commits into from
Aug 21, 2020

Conversation

prin-r
Copy link
Member

@prin-r prin-r commented Aug 11, 2020 •
edited
Loading

Implementation details

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@prin-r prin-r requested review from evilpeach and pzshine August 12, 2020 17:07
@evilpeach evilpeach requested a review from tansawit August 13, 2020 07:28
@render
Copy link

render bot commented Aug 16, 2020

Your Render PR Server URL is https://d3n-scan-pr-2455.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-bssdi8oti7jbdtbdhb40.

@prin-r prin-r force-pushed the unmock-copy-non-evm-proof branch from 8bc1e80 to 963e752 Compare August 18, 2020 04:37
tansawit
tansawit suggested changes Aug 18, 2020
View reviewed changes
scan/src/utils/proof/NonEVMProof.re Outdated Show resolved Hide resolved
scan/src/utils/proof/NonEVMProof.re Outdated Show resolved Hide resolved
scan/src/utils/proof/NonEVMProof.re Outdated Show resolved Hide resolved
scan/src/utils/proof/NonEVMProof.re Outdated Show resolved Hide resolved
scan/src/utils/proof/NonEVMProof.re Outdated Show resolved Hide resolved
scan/src/utils/proof/NonEVMProof.re Outdated Show resolved Hide resolved
@prin-r prin-r requested review from tansawit and evilpeach August 18, 2020 09:47
@evilpeach
Copy link
Contributor

Can we merge after revamped GuanYu version done?

@prin-r prin-r force-pushed the unmock-copy-non-evm-proof branch from 273da27 to b924f9b Compare August 21, 2020 14:10
prin-r added 2 commits August 21, 2020 21:15
@prin-r
implement proof with signature for non-evm
80900e4 
remove log

remove redundant

remove redindant

rebase master

fix from commentsw
@prin-r
copy only receive string
63d2b62
@prin-r prin-r force-pushed the unmock-copy-non-evm-proof branch from b924f9b to 63d2b62 Compare August 21, 2020 14:16
@evilpeach
Copy link
Contributor

@pzshine Can you check about design?

@prin-r prin-r merged commit 17435b3 into master Aug 21, 2020
@prin-r prin-r deleted the unmock-copy-non-evm-proof branch August 21, 2020 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tansawit tansawit tansawit approved these changes

@pzshine pzshine Awaiting requested review from pzshine

@evilpeach evilpeach Awaiting requested review from evilpeach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prin-r @evilpeach @tansawit