Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

go-owasm: Cleanup code documentation and error messages #2025

Merged
merged 9 commits into from
Jun 22, 2020

Conversation

sorawit
Copy link
Member

@sorawit sorawit commented Jun 21, 2020

  • Add doc comments for Span and VMLogic
  • Remove GoResult in favor of only use Error enum
  • Better error enum names and explanation

@sorawit sorawit requested review from Benzbeeb, taobun and perimeko June 21, 2020 11:19
@render
Copy link

render bot commented Jun 21, 2020

chain/x/oracle/types/exec_env.go Outdated Show resolved Hide resolved
@sorawit sorawit requested a review from taobun June 21, 2020 11:44
go-owasm/src/span.rs Outdated Show resolved Hide resolved
@sorawit sorawit requested a review from perimeko June 22, 2020 05:15
@taobun taobun merged commit 38463db into master Jun 22, 2020
@taobun taobun deleted the clean-up-go-owasm-error branch June 22, 2020 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants