Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

scan: implement ui and wireup redelegate modal #1985

Merged
merged 13 commits into from
Jun 17, 2020
Merged

scan: implement ui and wireup redelegate modal #1985

merged 13 commits into from
Jun 17, 2020

Conversation

tansawit
Copy link
Contributor

Fixes: #1968

@render
Copy link

render bot commented Jun 15, 2020

Your Render PR Server URL is https://d3n-scan-pr-1985.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-brjnfhl4pma3li10a79g.

@render
Copy link

render bot commented Jun 15, 2020

Your Render PR Server at https://d3n-scan-pr-1985.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brjnfhl4pma3li10a79g.

@render
Copy link

render bot commented Jun 15, 2020

Your Render PR Server at https://d3n-scan-pr-1985.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brjnfhl4pma3li10a79g.

@render
Copy link

render bot commented Jun 15, 2020

Your Render PR Server at https://d3n-scan-pr-1985.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brjnfhl4pma3li10a79g.

@render
Copy link

render bot commented Jun 15, 2020

Your Render PR Server at https://d3n-scan-pr-1985.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brjnfhl4pma3li10a79g.

@evilpeach evilpeach self-requested a review June 16, 2020 18:02
@render
Copy link

render bot commented Jun 16, 2020

Your Render PR Server at https://d3n-scan-pr-1985.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brjnfhl4pma3li10a79g.

evilpeach
evilpeach suggested changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's add the limit to 7 warning msg like undelegate msg modal.
  2. Add more gas
    image

scan/src/components/modal/submitTx/RedelegateMsg.re Outdated Show resolved Hide resolved
scan/src/components/modal/submitTx/RedelegateMsg.re Outdated Show resolved Hide resolved
scan/src/components/modal/ValidatorStakingInfo.re Outdated Show resolved Hide resolved
scan/src/components/modal/submitTx/RedelegateMsg.re Show resolved Hide resolved
@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1985.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brjnfhl4pma3li10a79g.

@evilpeach evilpeach requested review from evilpeach and sorawit June 17, 2020 07:17
@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1985.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brjnfhl4pma3li10a79g.

@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1985.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brjnfhl4pma3li10a79g.

@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1985.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brjnfhl4pma3li10a79g.

@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1985.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brjnfhl4pma3li10a79g.

@evilpeach evilpeach merged commit bbf0d8f into master Jun 17, 2020
@evilpeach evilpeach deleted the 1968-redelegate-ui-wireup branch June 17, 2020 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@sorawit sorawit sorawit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement UI + wire up for sending reledegate msg on modal
3 participants
@tansawit @sorawit @evilpeach