Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

go-owasm: Return error if writing beyond the provided span length #1936

Merged
merged 16 commits into from
Jun 15, 2020
Merged

go-owasm: Return error if writing beyond the provided span length #1936

merged 16 commits into from
Jun 15, 2020

Conversation

perimeko
Copy link
Contributor

fixed #1862

@render
Copy link

render bot commented Jun 11, 2020

Your Render PR Server URL is https://d3n-scan-pr-1936.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-brh29u98vr2di7lobbgg.

@render
Copy link

render bot commented Jun 11, 2020

Your Render PR Server at https://d3n-scan-pr-1936.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brh29u98vr2di7lobbgg.

@perimeko perimeko requested review from sorawit, taobun and Benzbeeb June 11, 2020 12:41
@render
Copy link

render bot commented Jun 11, 2020

Your Render PR Server at https://d3n-scan-pr-1936.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brh29u98vr2di7lobbgg.

@render
Copy link

render bot commented Jun 11, 2020

Your Render PR Server at https://d3n-scan-pr-1936.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brh29u98vr2di7lobbgg.

sorawit
sorawit suggested changes Jun 11, 2020
View reviewed changes
go-owasm/src/span.rs Outdated Show resolved Hide resolved
@perimeko perimeko requested a review from sorawit June 12, 2020 07:16
@render
Copy link

render bot commented Jun 12, 2020

Your Render PR Server at https://d3n-scan-pr-1936.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brh29u98vr2di7lobbgg.

@perimeko perimeko force-pushed the handle-span-exceed branch from fbd4b68 to af79627 Compare June 12, 2020 07:18
@render
Copy link

render bot commented Jun 12, 2020

Your Render PR Server at https://d3n-scan-pr-1936.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brh29u98vr2di7lobbgg.

@render
Copy link

render bot commented Jun 12, 2020

Your Render PR Server at https://d3n-scan-pr-1936.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brh29u98vr2di7lobbgg.

@render
Copy link

render bot commented Jun 12, 2020

Your Render PR Server at https://d3n-scan-pr-1936.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brh29u98vr2di7lobbgg.

sorawit
sorawit approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@sorawit sorawit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@render
Copy link

render bot commented Jun 15, 2020

Your Render PR Server at https://d3n-scan-pr-1936.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brh29u98vr2di7lobbgg.

@taobun taobun merged commit ae34419 into master Jun 15, 2020
@taobun taobun deleted the handle-span-exceed branch June 15, 2020 03:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@taobun taobun taobun approved these changes

@Benzbeeb Benzbeeb Benzbeeb approved these changes

@sorawit sorawit sorawit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go-owasm should error if writing beyond the provided span length
4 participants
@perimeko @sorawit @Benzbeeb @taobun