♻️ Fixed by comments

bandprotocol · Oct 2, 2020 · ff904c9 · ff904c9
1 parent 22d43a1
commit ff904c9
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 6 deletions.
diff --git a/scan/cypress/integration/send_action.spec.js b/scan/cypress/integration/send_action.spec.js
@@ -20,10 +20,10 @@ describe("Login", () => {
 describe("Send", () => {
   it("Status should be Success", () => {
     cy.get('[id="sendToken"]').contains("Send").click();
-    cy.get('[placeholder="Insert recipient address"]')
+    cy.get('[id="recipientAddressInput"]')
       .wait(1000)
       .type("band1mrdmxkhtr3rgfzfgrkxy5pvjtvnm5qq0my5m0x")
-      .get('[placeholder="Insert send amount"]')
+      .get('[id="sendAmountInput"]')
       .type("2");
     cy.get('[id="nextButton"]').contains("Next").click();
     cy.get('[id="broadcastButton"]').click();

diff --git a/scan/package.json b/scan/package.json
@@ -3,8 +3,7 @@
   "scripts": {
     "build": "rm -rf dist/ && bsb -make-world && parcel build index.html --no-source-maps --no-cache",
     "start": "bsb -make-world -w",
-    "test:dev": "yarn jest --coverage",
-    "test": "yarn test:dev",
+    "test": "yarn jest --coverage",
     "cy:run": "cypress run",
     "serve:build": "serve -s dist -l 3000",
     "integration-test": "start-server-and-test 'yarn run serve:build' http://localhost:3000 cy:run"

diff --git a/scan/src/components/EnhanceTxInput.re b/scan/src/components/EnhanceTxInput.re
@@ -85,6 +85,7 @@ let make =
       ~placeholder="",
       ~inputType="text",
       ~autoFocus=false,
+      ~id,
     ) => {
   let (status, setStatus) = React.useState(_ => Untouched);
 
@@ -101,6 +102,7 @@ let make =
     <Text value=msg size=Text.Lg spacing={Text.Em(0.03)} nowrap=true block=true />
     <div className={Styles.rightContainer(width)}>
       <input
+        id
         value={inputData.text}
         className={Css.merge([Styles.input, code ? Styles.code : ""])}
         placeholder

diff --git a/scan/src/components/UserAccount.re b/scan/src/components/UserAccount.re
@@ -166,8 +166,8 @@ let make = () => {
         <HSpacing size=Spacing.sm />
         <Icon name="fas fa-caret-down" color=Colors.bandBlue />
       </div>
-      <div className={Styles.profileCard(show)}>
-        <div id="addressWrapper"> <AddressRender address position=AddressRender.Text /> </div>
+      <div className={Styles.profileCard(show)} id="addressWrapper">
+        <AddressRender address position=AddressRender.Text />
         <VSpacing size={`px(16)} />
         <div className=Styles.innerProfileCard>
           <Balance address />

diff --git a/scan/src/components/modal/submitTx/DelegateMsg.re b/scan/src/components/modal/submitTx/DelegateMsg.re
@@ -94,6 +94,7 @@ let make = (~address, ~validator, ~setMsgsOpt) => {
          inputType="number"
          code=true
          autoFocus=true
+         id="delegateAmountInput"
        />;
      | _ => <EnhanceTxInput.Loading msg="Delegate Amount (BAND)" width=300 />
      }}

diff --git a/scan/src/components/modal/submitTx/RedelegateMsg.re b/scan/src/components/modal/submitTx/RedelegateMsg.re
@@ -197,6 +197,7 @@ let make = (~address, ~validator, ~setMsgsOpt) => {
          inputType="number"
          code=true
          autoFocus=true
+         id="redelegateAmountInput"
        />;
      | _ => <EnhanceTxInput.Loading msg="Amount (BAND)" width=300 />
      }}

diff --git a/scan/src/components/modal/submitTx/SendMsg.re b/scan/src/components/modal/submitTx/SendMsg.re
@@ -69,6 +69,7 @@ let make = (~address, ~receiver, ~setMsgsOpt) => {
       parse=Parse.address
       msg="Recipient Address"
       code=true
+      id="recipientAddressInput"
       placeholder="Insert recipient address"
       autoFocus={
         switch (toAddress.text) {
@@ -99,6 +100,7 @@ let make = (~address, ~receiver, ~setMsgsOpt) => {
            | _ => true
            }
          }
+         id="sendAmountInput"
        />;
      | _ => <EnhanceTxInput.Loading msg="Send Amount (BAND)" width=300 />
      }}

diff --git a/scan/src/components/modal/submitTx/SubmitTxModal.re b/scan/src/components/modal/submitTx/SubmitTxModal.re
@@ -130,6 +130,7 @@ module SubmitTxStep = {
         msg="Memo (optional)"
         placeholder="Insert memo"
         code=true
+        id="memoInput"
       />
       <VSpacing size=Spacing.lg />
       <VSpacing size=Spacing.md />

diff --git a/scan/src/components/modal/submitTx/UndelegateMsg.re b/scan/src/components/modal/submitTx/UndelegateMsg.re
@@ -108,6 +108,7 @@ let make = (~address, ~validator, ~setMsgsOpt) => {
          inputType="number"
          code=true
          autoFocus=true
+         id="undelegateAmountInput"
        />;
      | _ => <EnhanceTxInput.Loading msg="Undelegate Amount (BAND)" width=300 />
      }}