tests: install dependencies from poetry.lock instead of duplicating in tox.ini #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://python-poetry.org/docs/managing-dependencies/#dependency-groups: A note about defining a dev dependencies group The proper way to define a dev dependencies group since Poetry 1.2.0 is the following: [tool.poetry.group.dev.dependencies] pytest = "^6.0.0" pytest-mock = "*" This group notation is preferred since Poetry 1.2.0 and not usable in earlier versions. [...] Poetry will slowly transition away from the dev-dependencies notation which will soon be deprecated, so it’s advised to migrate your existing development dependencies to the new group notation.
Poetry >= 1.2 and tox >= 4.0 can coexist togheter, so that we do not have to duplicate the dependency specification in tox.ini. In the past, this has been a source of problems. source: Poetry FAQ "Is tox supported?" (https://python-poetry.org/docs/faq/#use-case-2)
muxator
force-pushed
the
use-poetry-for-tox-dependencies
branch
from
a5a6c00 to
e703f3a
Compare
added 6 commits
September 17, 2024 22:21
…durata dei test Qualora funzioni, splittare il changeset.
…otebooks" group in pyproject.toml
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 33 33
Lines 1751 1751
=======================================
Hits 1550 1550
Misses 201 201 |
…ust lints for now: COMPLETE_ME) The "make" command should be available on every supported platform in our Github CI runners.
muxator
force-pushed
the
use-poetry-for-tox-dependencies
branch
2 times, most recently
from
27bd518 to
d671b3f
Compare
muxator
force-pushed
the
use-poetry-for-tox-dependencies
branch
from
d671b3f to
379c280
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when tox is used to run the tests, various venvs are built reading the
dependenciessection intox.ini.Those dependencies are a subset of the dev dependencies listed in
pyproject.toml, and need to be kept synchronized (which hit us in the past).It seems that Poetry >= 1.2 and tox >= 4.0 can coexist togheter, see Poetry FAQ "Is tox supported?" (https://python-poetry.org/docs/faq/#use-case-2).
This PR is an attempt at using that strategy.