tests: remove pytest from the mypy execution environment #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 10, 2024 17:41
…ated and will be removed in a future release")
Before this change, the test log contained 37 entries like this:
PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
After this change, on my machine the test log shrinks from 1672 to 1405 lines
(16% less).
At some point in time, we will migrate to Pytest 8.x, and this would be an
hindrance.
A reference for the fix can be found at:
https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
Affected tests were found with:
rg "def (setup|teardown)\(" tests
Before this change, the log of the tests were littered with messages from
Pillow:
2024-09-10 18:04:55 [ DEBUG] STREAM b'IHDR' 16 13 (PngImagePlugin.py:197)
2024-09-10 18:04:55 [ DEBUG] STREAM b'sBIT' 41 4 (PngImagePlugin.py:197)
2024-09-10 18:04:55 [ DEBUG] b'sBIT' 41 4 (unknown) (PngImagePlugin.py:753)
2024-09-10 18:04:55 [ DEBUG] STREAM b'pHYs' 57 9 (PngImagePlugin.py:197)
After this change, on my machine, the size of the log produced by running
"make test" goes from 1405 to 513 lines, a 63% reduction, that hopefully
increases the signal noise ratio of the test logs.
We have meaningful doctests in the code base. Before this change, their execution had to be manually activated in Makefile and tox.ini. This change centralizes the option in pytest.ini, so that we reduce the future occurrence of human errors (less duplication, less oversights).
Pytest is not needed for static type checking. Since tox.ini contains a duplicated list of dependencies (the authoritative one is in pyproject.toml), it is better to keep the one in tox.ini as short as possible.
muxator
force-pushed
the
remove-pytest-from-mypy-in-tox-ini
branch
from
d5964ec to
b04a7e8
Compare
|
Withdrawing this PR: the tests themselves contain refererences to Pytest; mypy needs to have access to it (https://github.com/bancaditalia/black-it/actions/runs/10846166500/job/30098563227?pr=87). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytest is not needed for static type checking. Since
tox.inicontains a duplicated list of dependencies (the authoritative one is inpyproject.toml), it is better to keep the one intox.inias short as possible.