Update poetry.lock and pyproject.toml, add CI check on poetry.lock
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 89.22% 89.22%
=======================================
Files 42 42
Lines 1782 1782
=======================================
Hits 1590 1590
Misses 192 192
|
marcofavoritobi
force-pushed
the
update-poetry-lock
branch
from
fb56dd2 to
3eb5350
Compare
marcofavoritobi
force-pushed
the
update-poetry-lock
branch
from
3eb5350 to
b165038
Compare
marcofavoritobi
commented
Sep 22, 2023
marcofavoritobi
changed the title
poetry.lock and pyproject.toml, add CI check on poetry.lock
marcofavoritobi
force-pushed
the
update-poetry-lock
branch
3 times, most recently
from
980a645 to
2a2065a
Compare
We also update the deps sections in tox.ini so to make the testenvs synchronized with poetry.lock.
Notable packages whose version specifier has changed are: - scikit-learn: from ^1.2.2 to ^1.3.1 - joblib: from ^1.2.0 to ^1.3.2
This commit adds a PHONY Makefile target 'poetry-lock-check' that runs the command 'poetry check --lock'. This target is then used as first step in the CI lint workflow.
marcofavoritobi
force-pushed
the
update-poetry-lock
branch
from
4424a93 to
2ab181c
Compare
muxator
reviewed
Sep 22, 2023
muxator
force-pushed
the
update-poetry-lock
branch
from
5148a11 to
f64b313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply refreshes the dependencies by running
poetry update. Then, the dependency sections oftox.iniare synchronized with the new content ofpoetry.lock.Also
pyproject.tomlis synchronized with the newpoetry.lock, although the update required a couple of cyclic iteration withpoetry lockuntil convergence.The new version of
numpyhad some breaking changes which affected the correct behaviour of the library. The errors have been fixed 3eb5350.Moreover, we added a CI step that checks whether
poetry.lockis up-to-date.