Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to tests #68

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Minor fix to tests #68

merged 5 commits into from
Sep 19, 2023

Conversation

marcofavoritobi
Copy link
Contributor

@marcofavoritobi marcofavoritobi commented Sep 18, 2023

Proposed changes

Do minor fixes to tests:

  • skip TestPlotSampling test on Windows, due to flakiness;
  • fix bug in BH4
  • add reproducibility tests for BH models
  • remove e2e mark to TestMainExample.
  • remove duplication of BH4 and NormalV in fixtures.test_models

@codecov-commenter
Copy link

Codecov Report

Merging #68 (39ee0d5) into main (c5a5b88) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   91.36%   91.38%   +0.01%     
==========================================
  Files          42       42              
  Lines        1737     1729       -8     
==========================================
- Hits         1587     1580       -7     
+ Misses        150      149       -1     

see 1 file with indirect coverage changes

@marcofavoritobi marcofavoritobi merged commit e2f161a into main Sep 19, 2023
10 checks passed
@marcofavoritobi marcofavoritobi deleted the minor-fix-to-tests branch September 25, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants