Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix flaky tox command on Windows platform (fix #65) #66

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

marcofavoritobi
Copy link
Contributor

Fix issue #65 by parsing the output of tox looking for "success" messages (despite the internal code of tox fails).

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Merging #66 (16eeffa) into main (80a642a) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files          42       42           
  Lines        1737     1737           
=======================================
  Hits         1587     1587           
  Misses        150      150           

@marcofavoritobi
Copy link
Contributor Author

The fix worked, e.g. see https://github.com/bancaditalia/black-it/actions/runs/6073294808/job/16474939464:

=== 83 passed, 18 skipped, 2 deselected, 191 warnings in 150.28s (0:02:30) ====
Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\site-packages\tox\session\cmd\run\single.py", line 105, in run_command_set
    current_outcome = tox_env.execute(
.pkg: _exit> python C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\site-packages\pyproject_api\_backend.py True poetry.core.masonry.api
RuntimeError: <_overlapped.Overlapped object at 0x000001CAFC209C00> still has pending operation at deallocation, the process may crash
  py39: OK (599.33=setup[446.28]+cmd[153.05] seconds)
  congratulations :) (599.81 seconds)
Tests were successful!

@marcofavoritobi marcofavoritobi merged commit c6bba8c into main Sep 4, 2023
@marcofavoritobi marcofavoritobi deleted the fix-65 branch September 4, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants