Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip plotting tests on Windows due to flakiness #63

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

marcofavoritobi
Copy link
Contributor

@marcofavoritobi marcofavoritobi commented Sep 1, 2023

Proposed changes

Skip plotting tests on Windows due to flakiness, e.g.:

Fix pyver extraction in Windows: ba0c231

In GH workflows, split notebook tests from main tests for better clarity: 865b97f

@marcofavoritobi marcofavoritobi changed the title Skip TestPlotLosses tests on Windows due to flakiness Skip plotting tests on Windows due to flakiness Sep 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #63 (c519679) into main (7a1e9b0) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   91.36%   91.27%   -0.09%     
==========================================
  Files          42       42              
  Lines        1737     1731       -6     
==========================================
- Hits         1587     1580       -7     
- Misses        150      151       +1     

see 7 files with indirect coverage changes

@marcofavoritobi marcofavoritobi force-pushed the skip-flaky-tests-on-windows branch 5 times, most recently from e380bd3 to c519679 Compare September 1, 2023 14:41
@marcofavoritobi marcofavoritobi force-pushed the skip-flaky-tests-on-windows branch from c519679 to ac8acf4 Compare September 1, 2023 14:52
@marcofavoritobi marcofavoritobi merged commit 888f33e into main Sep 1, 2023
@marcofavoritobi marcofavoritobi deleted the skip-flaky-tests-on-windows branch September 1, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants