Fix mypy tox task #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is needed because some dependencies already have type hinting that otherwise would not be exploited; and instead of listing them as dependencies, we use a more flexible configuration that does not require maintainance in case of dependency update. It will increase the running time of the mypy tox task a bit though.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 34 34
Lines 1563 1563
=======================================
Hits 1515 1515
Misses 48 48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix: tox mypy job testenv installs the package
this change is needed because some dependencies already have type hinting that otherwise
would not be exploited; and instead of listing them as dependencies, we use
a more flexible configuration that does not require maintenance in case of dependency updates.
It will increase the running time of the mypy tox task a bit though.
Fixes
n/a
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.Further comments
n/a