Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove hypothesis deadline in test_seedable tests #55

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

marcofavoritobi
Copy link
Contributor

Proposed changes

This change was suggested by this failure on CI:

https://github.com/bancaditalia/black-it/actions/runs/4536853579/jobs/7994037834

By removing the hypothesis deadline to the above tests, it should work as usual.

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

This change was suggested by this failure on CI:

    https://github.com/bancaditalia/black-it/actions/runs/4536853579/jobs/7994037834

By removing the hypothesis deadline to the above tests, it should work as usual.
@codecov-commenter
Copy link

Codecov Report

Merging #55 (f3eb3d7) into main (662a549) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          34       34           
  Lines        1563     1563           
=======================================
  Hits         1515     1515           
  Misses         48       48           

@marcofavoritobi marcofavoritobi merged commit 933311c into main Mar 28, 2023
@marcofavoritobi marcofavoritobi deleted the test-hypothesis-flakiness branch March 28, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants